Skip to content

Conversation

@sheland
Copy link

@sheland sheland commented Nov 29, 2018

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Asynchronous code takes statements outside of the main program flow, allowing the code after the asynchronous call to be executed immediately without waiting while synchronous code is executed in sequence
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Axios' requests
What kind of errors might the API give you? How did you choose to handle them? cannot make reservation, or if you try to send a form with empty fields, it will show you the error msg.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. I don't believe it would make a difference, when a user clicks on a trip, the click obtains the trip's id.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good commit messages and good number of commits
Comprehension questions Check, Good answers
Functionality
Click a button to load and view a list of trips Check
Click a trip to load and view trip details Check
Fill out a form to reserve a spot Check
Errors are reported to the user No messages about errors connecting to the API when that fails on selecting an individual trip, but validation errors do present good error messages, and error messages are shown for loading all the trips.
CSS is DRY and attractive, uses CSS Grid, flexbox, and/or Bootstrap No styling at all.
Under the Hood
Trip data is retrieved using from the API Check
JavaScript is well-organized and easy to read Check, lots of comments, good for understanding.
HTML is semantic Check
Overall Well done, you hit the learning goals, even if it was hard and you didn't get the styling in.

tripDetailsList.append(`<li>Cost: ${tripData.cost}</li>`);
tripDetailsList.append(`<li>Weeks: ${tripData.weeks}</li>`);
tripDetailsList.append(`<li>About: ${tripData.about}</li>`);
})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need a catch to handle errors here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants