Maddie Shields - Edges - Trek #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TREKWhat We're Looking For
Great work on this Maddie! I've added a few comments about a few small things. Otherwise, I'd consider your code to be very functional, very action-packed, and very fancy. Good work! |
tildeee
reviewed
Dec 11, 2018
| .then((response) => { | ||
| tripInfo.append(getInfo(response.data)) | ||
| .append(loadForm()); | ||
| $('#reservation-form').submit(function(event) { createReservation(event, tripID); }); |
tildeee
reviewed
Dec 11, 2018
| event.preventDefault(); | ||
| axios.post(getReservationURL(tripID), reservationFormData()) | ||
| .then((response) => { | ||
| reportStatus(`Successfully added a reservation with ID ${response.data.trip_id}!`); |
There was a problem hiding this comment.
This text says that the reservation has an ID... but you put into the message the trip's ID! hahaha
tildeee
reviewed
Dec 11, 2018
|
|
||
| $('#load-trips-button').on('click', function() { | ||
| $('#list').slideDown('slow'); | ||
| loadTrips(null); |
tildeee
reviewed
Dec 11, 2018
| .promise().done(function() { | ||
| getTrip(event.target.classList[1]); | ||
| $('.side-info').slideDown('slow'); | ||
| }); |
There was a problem hiding this comment.
This could be even fancier if you found a way to move the getTrip() call into the loadTrips function when you create each trip listing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TREK
Congratulations! You're submitting your assignment!
Comprehension Questions
Tripin the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.