Ports - Heather

[piffer59]

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	The Model talks to external databases
Describe in your own words what the Controller is doing in Rails	It is pulling the data from the Model using different actions.
Describe in your own words what the View is doing in Rails	Displays the data that has been pulled by the Controller
Describe an edge-case controller test you wrote	Returning a not found message when a task is not found.
What is the purpose of using strong params? (i.e. the params method in the controller)	Helps to increase security, they prevent accidentally allowing users to update model attributes.
How are Rails migrations related to Rails models?	migrations allow you to change your model
Describe one area of Rails that are still unclear on	Testing Controller methods is still confusing

[tildeee]

Task List

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in	x
Answered comprehension questions	x
Successfully handles: Index, Show	x
Index & Show tests pass	x
Successfully handles: New, Create	x
New & Create tests pass	x
Successfully handles: Edit, Update	x
Tests for Edit & Update test valid & invalid task ids	x
Successfully handles: Destroy, Task Complete	x
Tests for Destroy & Task Complete include tests for valid and invalid task ids	x
Routes follow RESTful conventions	x
Uses named routes (like _path)	x
Overall

Well done on this project, Heather!

Your project hits all the things I was looking for: following Rails best practices, RESTful routing, and CRUD.

The places of improvement that I have noted are:

• You have defined a strong params method task_params, but you don't use it anywhere! Your project will be better off using the strong params method
• You have a few unused lines of code

There are also just a few other comments I have

Also, you used some of the live code copy (like "MAKE! THAT! task!"), so don't forget to change small details like that to make this app your own :) :) :) (Not a big deal, just something that might feel nice for yourself)

That being said, your project looks pretty good. Great work!

[tildeee]

Don't forget to refactor your code often, so you remember to delete unused variables like this!

[tildeee]

This is a place where you can refactor this to use task_params instead of outlining name and description

[tildeee]

You'd probably want to delete your puts!

[tildeee]

Strong params!

[tildeee]

What does this line do? Your tests still pass when I remove this line, and also the app still seems to work

[tildeee]

this view and the logic in it looks good! You may want to mind your indentation though