Open
Conversation
Task ListWhat We're Looking For
|
CheezItMan
reviewed
Apr 17, 2019
| get "/tasks/:id/edit", to: "tasks#edit", as: "edit_task" | ||
| patch "/tasks/:id", to: "tasks#update" | ||
|
|
||
| patch "/tasks/:id/mark_complete", to: "tasks#mark_complete", as: "mark_complete" |
There was a problem hiding this comment.
Just a note, that you don't need 2 routes to toggle the task between complete and incomplete, you could do it with one.
| if task.save | ||
| redirect_to root_path | ||
| else | ||
| render :new |
| def edit | ||
| @task = Task.find_by(id: params[:id]) | ||
| if @task.nil? | ||
| flash[:error] = "Could not find task with id: #{params[:id]}" |
| # Assert | ||
| must_respond_with :redirect | ||
| expect(flash[:error]).must_equal "Could not find task with id: -1" | ||
| must_respond_with 302 |
There was a problem hiding this comment.
I suggest using the rails symbols for response codes instead of using the numbers. It's just more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task List
Congratulations! You're submitting your assignment!
Comprehension Questions