Ports -- Kate

[goblineer]

Task List

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe in your own words what the Model is doing in Rails	The Model is how the data comes into the app and the structure for how it's organized into a database.
Describe in your own words what the Controller is doing in Rails	The controller contains all of the business logic in the app. It mediates between the view and the model and sends requests to the proper routes.
Describe in your own words what the View is doing in Rails	The View dictates how the data and accompanying HMTL will be seen and perhaps manipulated by the user. It includes form views the index page and all of the visible wrappers (navbars, adornments, etc).
Describe an edge-case controller test you wrote
What is the purpose of using strong params? (i.e. the params method in the controller)	Strong params prevent things from going ... off the rails.
How are Rails migrations related to Rails models?	Migrations are done when structural changes are made to the databases, when the model has been updated.
Describe one area of Rails that are still unclear on	TDD

[CheezItMan]

Task List

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with no extraneous files checked in	You do need more commits for this project.
Answered comprehension questions	A less flippant answer to strong params would be appreciated.
Successfully handles: Index, Show	Yes, when I manually create the tasks
Index & Show tests pass	No
Successfully handles: New, Create	No, you are not setting some fields you've made as required.
New & Create tests pass	No
Successfully handles: Edit, Update	Check
Tests for Edit & Update test valid & invalid task ids	No
Successfully handles: Destroy, Task Complete	Destroy works, marking complete doesn't seem to
Tests for Destroy & Task Complete include tests for valid and invalid task ids	No
Routes follow RESTful conventions	Check
Uses named routes (like _path)	Check
Overall	Did you change your migrations after they were run? Your schema doesn't match the migrations and so I'm having a hard time getting it to run. Generally once you've made a migration, don't touch the file, make another to undo that change. You also did no testing. This isn't a good start to Rails. I'd like to go through things on this project with you to make sure you have a solid foundation for rails. I know you were out a few days, and we need to get this handled soon.

[CheezItMan]

Your Task model doesn't have a completed_at field. Instead I would simply make this line:

<p><%= task.completed ? "Completed": "Incomplete" %></p>

[CheezItMan]

You don't have a completed_at field, instead maybe just return completed.

[CheezItMan]

I'm getting an error that ERROR: null value in column "completed_at" violates not-null constraint, this means you have a field completed_at that can't be nil, but you're not setting it in your strong params.

[CheezItMan]

This migration doesn't seem to be in your schema.