Niv #10
Open
Niv #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Oct 4, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Ok so some issues here. Take a look at my comments on time and space complexity and look at my heap-down method. You need to compare the current index with both of it's children, not just the left-child.
Comment on lines
17
to
18
| # Time Complexity: ? | ||
| # Space Complexity: ? |
There was a problem hiding this comment.
Since you're doing recursion it should be O(log n) for both.
Comment on lines
+64
to
+67
| def find_parent(index) | ||
| parent_index = (index - 1)/2 | ||
| return parent_index | ||
| end |
| if @store[parent_index].key <= @store[index].key || index == 0 | ||
| return | ||
| end | ||
| if @store[parent_index].key > @store[index].key |
There was a problem hiding this comment.
Since your prior if statement returns you don't need an if statement here.
| raise NotImplementedError, "Method not implemented yet..." | ||
| puts 'heap down' | ||
| puts to_s | ||
| child_index = 2*index + 1 |
There was a problem hiding this comment.
You are only finding the left child here. You are not finding the right child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?