forked from AdaGold/heaps
-
Notifications
You must be signed in to change notification settings - Fork 34
Elle #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dev-elle-up
wants to merge
2
commits into
Ada-C11:master
Choose a base branch
from
dev-elle-up:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Elle #14
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,26 @@ | ||
|
|
||
| require_relative "min_heap" | ||
| # require 'pry' | ||
|
|
||
| # This method uses a heap to sort an array. | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| def heap_sort(list) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| end | ||
| # Time Complexity: O(nlogn),where n is the number of items in the list, | ||
| # because the add and remove methods are O(nlogn) | ||
| # Space Complexity: O(2n), where n is the number of items in the list | ||
| def heapsort(list) | ||
| return list if list.length < 2 | ||
|
|
||
| heap = MinHeap.new | ||
|
|
||
| i = 0 | ||
| list.each do | ||
| heap.add(list[i]) | ||
| i += 1 | ||
| end | ||
|
|
||
| i = 0 | ||
| until i == list.length | ||
| list[i] = heap.remove | ||
| i += 1 | ||
| end | ||
|
|
||
| return list | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,18 +14,24 @@ def initialize | |
| end | ||
|
|
||
| # This method adds a HeapNode instance to the heap | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(nlogn) because heap_up is nlogn, where n is the number of nodes in the heap | ||
| # Space Complexity: O(1) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since |
||
| def add(key, value = key) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| @store << HeapNode.new(key, value) | ||
| index = @store.length-1 | ||
| heap_up(index) if @store.length > 1 | ||
| end | ||
|
|
||
| # This method removes and returns an element from the heap | ||
| # maintaining the heap structure | ||
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(nlogn), where n is the number of nodes in the heap | ||
| # Space Complexity: O(1) | ||
| def remove() | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| return nil if empty? | ||
| swap(0, @store.length-1) | ||
| removed_item = @store.pop | ||
| heap_down(0) if @store.length > 1 | ||
| return removed_item.value | ||
| end | ||
|
|
||
|
|
||
|
|
@@ -44,28 +50,47 @@ def to_s | |
| end | ||
|
|
||
| # This method returns true if the heap is empty | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time complexity: O(1) | ||
| # Space complexity: O(1) | ||
| def empty? | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| return @store.empty? | ||
| end | ||
|
|
||
| private | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap, if it is less than it's parent node. | ||
| # It could be **very** helpful for the add method. | ||
| # Time complexity: ? | ||
| # Space complexity: ? | ||
| # Time Complexity: O(nlogn), where n is the number of nodes in the heap | ||
| # Space Complexity: O(1) | ||
| def heap_up(index) | ||
|
|
||
| return if index == 0 | ||
| parent_index = find_parent_index(index) # O(1) | ||
| if @store[parent_index].key > @store[index].key | ||
| swap(parent_index, index) # O(1) | ||
| heap_up(parent_index) | ||
| end | ||
| end | ||
|
|
||
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) | ||
| raise NotImplementedError, "Method not implemented yet..." | ||
| def heap_down(parent_index) | ||
| left_child_index = find_left_child_index(parent_index) | ||
| right_child_index = find_right_child_index(parent_index) | ||
| smallest = 0 | ||
|
|
||
| return if !@store[left_child_index] | ||
|
|
||
| if !@store[right_child_index] || @store[left_child_index].key < @store[right_child_index].key | ||
| smallest = left_child_index | ||
| else | ||
| smallest = right_child_index | ||
| end | ||
|
|
||
| if @store[smallest].key < @store[parent_index].key | ||
| swap(smallest, parent_index) | ||
| end | ||
| end | ||
|
|
||
| # If you want a swap method... you're welcome | ||
|
|
@@ -74,4 +99,19 @@ def swap(index_1, index_2) | |
| @store[index_1] = @store[index_2] | ||
| @store[index_2] = temp | ||
| end | ||
|
|
||
| # These helper methods find the index of the | ||
| # current item's parent node, and the indices | ||
| # of its left and right children | ||
| def find_parent_index(node_index) | ||
| return ((node_index-1)/2).floor | ||
| end | ||
|
|
||
| def find_left_child_index(node_index) | ||
| return node_index * 2 + 1 | ||
| end | ||
|
|
||
| def find_right_child_index(node_index) | ||
| return node_index * 2 + 2 | ||
| end | ||
|
Comment on lines
+103
to
+116
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good set of helper methods. |
||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So really O(n)