Skip to content

Conversation

@MiraMarshall
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar They both use can be used to layout content and position elements.
Give one example where you choose Flexbox over Grid I used Flexbox to align my elements in different sections (nav, why, team).
Where did you choose to use CSS Grid and why did you make that decision I wrapped all of the content with CSS Grid to get a set two-dimensional outline of the project with columns and rows. Then positioned the content mainly the rows using Flexbox.
What was the hardest part of this assignment, and why was it difficult Positioning the elements, specifically in the 'why' section was difficult because I had trouble getting the paragraph content to line up with the images.
What concept did you get the most clarity on through Startrly? How CSS Grid and Flexbox can work together for webpage layouts.

Copy link

@RPerry RPerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the nav and title part of your code. I didn't really comment on the team class as I know you're still working on it but overall, it looks great!

index.html Outdated
<span>Dee Dugong</span>
<span>Startup Enthusiast</span>
</li>
<div class="first-3">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you separated the first 3 team members into a different class to keep them on separate lines. Was this so that the two classes stay on different lines regardless of the size of the browser?

.container{
display: grid;
grid-template: auto 2fr 2fr 2fr 2fr 2fr 3.5fr 2fr auto / 2fr 1fr 1fr;
grid-template-areas:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll definitely try using grid-template-areas next time


}

.tagline {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your nav and tagline classes are designed so well and look great in the browser!

font-style: italic;
}

blockquote:before {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea you could add quotes in css

main.css Outdated

} */

.why ul li{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use vertical-align: top, you can align strong and p to be right over each other.

main.css Outdated
border-radius: 50%;

}
.first-three {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you put the flex-direction directly within the classes, it'll put the first 3 team-members on the first row and the rest on the second row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants