-
Notifications
You must be signed in to change notification settings - Fork 48
Ports - Shamira #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ports - Shamira #22
Conversation
RPerry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the nav and title part of your code. I didn't really comment on the team class as I know you're still working on it but overall, it looks great!
index.html
Outdated
| <span>Dee Dugong</span> | ||
| <span>Startup Enthusiast</span> | ||
| </li> | ||
| <div class="first-3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you separated the first 3 team members into a different class to keep them on separate lines. Was this so that the two classes stay on different lines regardless of the size of the browser?
| .container{ | ||
| display: grid; | ||
| grid-template: auto 2fr 2fr 2fr 2fr 2fr 3.5fr 2fr auto / 2fr 1fr 1fr; | ||
| grid-template-areas: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll definitely try using grid-template-areas next time
|
|
||
| } | ||
|
|
||
| .tagline { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your nav and tagline classes are designed so well and look great in the browser!
| font-style: italic; | ||
| } | ||
|
|
||
| blockquote:before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no idea you could add quotes in css
main.css
Outdated
|
|
||
| } */ | ||
|
|
||
| .why ul li{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you use vertical-align: top, you can align strong and p to be right over each other.
main.css
Outdated
| border-radius: 50%; | ||
|
|
||
| } | ||
| .first-three { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you put the flex-direction directly within the classes, it'll put the first 3 team-members on the first row and the rest on the second row.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions