-
Notifications
You must be signed in to change notification settings - Fork 48
Sockets - Nidhi #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sockets - Nidhi #24
Conversation
piffer59
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your code looked really dry. Nice job! I found looking at your code really helpful.
| font-weight: bold; | ||
| text-align: left; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Organizing the navbar into a grid was a clean way to do this. Is it possible to do this with fewer columns and make them of different widths?
| text-align: left; | ||
| } | ||
|
|
||
| .title{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By setting this up as a grid you avoided having to do weird things with the , that's great!
|
|
||
| .quote { | ||
| border-bottom: 2px solid grey; | ||
| border-top: 2px solid grey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job combining these border styles
| } | ||
|
|
||
| blockquote, blockquote + p { | ||
| font-style: italic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to add this to the .quote declaration above.
| @@ -0,0 +1,142 @@ | |||
| * { | |||
| font-family: 'Nanum Gothic', sans-serif; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could try importing a Google font at the top of this file
| margin: auto; | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr 1fr | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can try adding a grid inside of a grid that may help you align your text here.
| } | ||
|
|
||
| ul { | ||
| padding-inline-start: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
| grid-template-columns: 1fr 1fr 1fr | ||
| } | ||
|
|
||
| .sponsors { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you did this section
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions