-
Notifications
You must be signed in to change notification settings - Fork 48
Ports - Ari #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Ports - Ari #25
Conversation
paulentine
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how precisely you matched the layout with the wireframe! Layout looks clean and modern, and implementation under the hood was well-organized and easy to read. Fantastic job!
| align-items: center; | ||
| width: auto; | ||
| } | ||
| /* navigation formatting */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments indicating which section is being styled are really helpful!
| text-decoration: none; | ||
| } | ||
|
|
||
| a[href="#"]:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Call to action is very visible and has a beautiful hover color.
| font-family: 'Raleway'; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| src: local('Raleway'), local('Raleway-Regular'), url(https://fonts.gstatic.com/s/raleway/v13/1Ptug8zYS_SKggPNyC0IT4ttDfA.woff2) format('woff2'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat, I didn't know you can add a font purely in CSS (without adding an external stylesheet reference in the HTML)!
|
|
||
| } | ||
|
|
||
| img[alt*="profile"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love how you target the profile images with alt attribute!
| .footer { | ||
| display: flex; | ||
| flex-direction: row; | ||
| background-color: rgb(121, 203, 201); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Footer section looks classy! Love how you used RGB colors here.
| <nav> | ||
| <ul> | ||
| <li> | ||
| <ul class="navigation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat use of class names to target which part you'd like to style!
| #team ul { | ||
| grid-row: 2 span 3; | ||
| display: flex; | ||
| flex-wrap: wrap; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Responsive! Nice!
| margin: 0.5rem; | ||
| } | ||
|
|
||
| section:nth-last-of-type(2) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat way to target & add border :)
| </blockquote> | ||
| <p> | ||
| Mx. Lorem | ||
| -- Mx. Lorem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can prepend -- using CSS' ::before pseudo-element :)
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions