Skip to content

Conversation

@aribray
Copy link

@aribray aribray commented Apr 5, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar both help you organize layout in CSS
Give one example where you choose Flexbox over Grid If I only needed to have the elements move in one direction rather than in two directions, I chose Flexbox.
Where did you choose to use CSS Grid and why did you make that decision I used grid in the navigation menu so that I could pick the specific column for each of the navigation elements.
What was the hardest part of this assignment, and why was it difficult The hardest part was finding the time to do it. The second hardest part was figuring out when to use flex over grid. I still don't understand how grids are set up/how many columns and rows are created and when.
What concept did you get the most clarity on through Startrly? This was good for figuring the cascading and inheritance pieces of CSS. The parts about flex and grid are still 60% mystery to me, but I did learn a lot about those too.

Copy link

@paulentine paulentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how precisely you matched the layout with the wireframe! Layout looks clean and modern, and implementation under the hood was well-organized and easy to read. Fantastic job!

align-items: center;
width: auto;
}
/* navigation formatting */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments indicating which section is being styled are really helpful!

text-decoration: none;
}

a[href="#"]:hover {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Call to action is very visible and has a beautiful hover color.

font-family: 'Raleway';
font-style: normal;
font-weight: 400;
src: local('Raleway'), local('Raleway-Regular'), url(https://fonts.gstatic.com/s/raleway/v13/1Ptug8zYS_SKggPNyC0IT4ttDfA.woff2) format('woff2');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat, I didn't know you can add a font purely in CSS (without adding an external stylesheet reference in the HTML)!


}

img[alt*="profile"] {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how you target the profile images with alt attribute!

.footer {
display: flex;
flex-direction: row;
background-color: rgb(121, 203, 201);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Footer section looks classy! Love how you used RGB colors here.

<nav>
<ul>
<li>
<ul class="navigation">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat use of class names to target which part you'd like to style!

#team ul {
grid-row: 2 span 3;
display: flex;
flex-wrap: wrap;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responsive! Nice!

margin: 0.5rem;
}

section:nth-last-of-type(2) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat way to target & add border :)

</blockquote>
<p>
Mx. Lorem
-- Mx. Lorem

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can prepend -- using CSS' ::before pseudo-element :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants