-
Notifications
You must be signed in to change notification settings - Fork 48
Sockets - Evelynn #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| <section id="footer"> | ||
| <div> | ||
| <h3>Support</h3> | ||
| <ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you utilize different fonts from Google Font to make your page looks unique. You followed the project requirement closely and placed the normalize.css style file before your style file. That's great! For the Google Font, you could also add it to your css file using @import url (this would not require adding this font to the html file). :)
| align-items: center; | ||
| flex-wrap: wrap; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blockquote wrapped very well when I adjusted the screen size. One improvement that you could make is to display the quotation marks around the quote, using blockquote::before {content: open-quote;} and blockquote::after{content: close-quote;}
| margin-right: 10px; | ||
| float: left; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did a great job with the why section, the content wrapped very well, all image and corresponding text stay on the same line even for smaller window.
| display: block; | ||
| margin: 5px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This team section display looks like the wireframe provided by client when I size down the window but not when I have the window on full-size. To get it looks similar to the wireframe, you could use grid :)
| flex-wrap: wrap; | ||
| list-style: none; | ||
| justify-content: space-around; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sponsor section is currently aligned top, if you change it to center then it would look closer to the wireframe :)
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions