Skip to content

Conversation

@evelynnkaplan
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar They allow for manipulation of how a group of elements appear on the screen.
Give one example where you choose Flexbox over Grid I chose Flexbox to organize the "Meet our Team" section to make the image placement more flexible depending on screen size.
Where did you choose to use CSS Grid and why did you make that decision I used a grid for the footer because I wanted every to align evenly on an axis.
What was the hardest part of this assignment, and why was it difficult Deciding how to lay specific pieces out because it can be hard to tell from a wireframe whether or not a grid or a flexbox was used.
What concept did you get the most clarity on through Startrly? How to use grid and Flexbox.

<section id="footer">
<div>
<h3>Support</h3>
<ul>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you utilize different fonts from Google Font to make your page looks unique. You followed the project requirement closely and placed the normalize.css style file before your style file. That's great! For the Google Font, you could also add it to your css file using @import url (this would not require adding this font to the html file). :)

align-items: center;
flex-wrap: wrap;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blockquote wrapped very well when I adjusted the screen size. One improvement that you could make is to display the quotation marks around the quote, using blockquote::before {content: open-quote;} and blockquote::after{content: close-quote;}

margin-right: 10px;
float: left;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did a great job with the why section, the content wrapped very well, all image and corresponding text stay on the same line even for smaller window.

display: block;
margin: 5px;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This team section display looks like the wireframe provided by client when I size down the window but not when I have the window on full-size. To get it looks similar to the wireframe, you could use grid :)

flex-wrap: wrap;
list-style: none;
justify-content: space-around;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sponsor section is currently aligned top, if you change it to center then it would look closer to the wireframe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants