Sockets - Hana #29
Open
Sockets - Hana #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minams
reviewed
Apr 5, 2019
minams
left a comment
minams
left a comment
There was a problem hiding this comment.
Hana - you did an amazing job! I really enjoyed looking at the various ways you approached changing specific things. The choices you made are really clear and really easy to follow. I also looooved the background color you applied -- very soft on the eyes! This looks amazing! A+++++!!!
| <section class="menu"> | ||
| <div> | ||
| <h3>Support</h3> | ||
| <ul> |
There was a problem hiding this comment.
I like how you organized and segmented each portion of the HTML.
| justify-content: center; | ||
| background-color: #CDD6DD; | ||
| } | ||
|
|
| <div> | ||
| <body class="pagecontainer"> | ||
| <div class="container"> | ||
|
|
There was a problem hiding this comment.
Good differentiating between the classes here. I like how you used names that are specific and understandable!
| text-decoration: none; | ||
| color: black; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is such a cool thing you did here and a great way to showcase different ways of approaching targeting items.
| display: grid; | ||
| grid-template-areas: "a b c"; | ||
| } | ||
|
|
|
|
||
| .quote p:before { | ||
| content: "--"; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions