-
Notifications
You must be signed in to change notification settings - Fork 48
Sockets - Kirsten #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
goblineer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spectacular implementation! Gold stars galore.
I had trouble setting up my review, so let's talk out loud since that will be a better use of time.
| </head> | ||
| <body> | ||
| <div> | ||
| <div class="container"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, whole page in a container -- maybe a good place for a huuuuge grid to help with layout (with which you don't need more help, as your layout looks pixel-perfect). Do you style this class anywhere?
| <section id="footer"> | ||
| <div> | ||
| <h3>Support</h3> | ||
| <ul> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The HTML is changed only to add ids. Nicely done! ID rather than class is a choice toward specificity but doesn't allow reusing styling in a flexible way. Are there areas where you wrote the same CSS for two different ids?
| padding: 0px; | ||
| display: inline-grid; | ||
| grid-template: 250px 250px / 20% 20% 20% 20% 20%; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice template! The absolute values for each cell's size are preventing the resizing you want.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions