Skip to content

Conversation

@kanderson38
Copy link

@kanderson38 kanderson38 commented Apr 5, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar They both let the programmer customize alignment by taking elements out of the normal block/inline/inline-block flow in HTML.
Give one example where you choose Flexbox over Grid I chose flexbox for the Sponsors section because the images needed to wrap and be centered relative to their container, and didn't need to be aligned in a specific way (as they would have been in a grid).
Where did you choose to use CSS Grid and why did you make that decision I used CSS Grid in the nav, the "Why?" section, and the "Team" section, because the elements needed to be precisely aligned relative to each other and to the page edges, and some elements needed to be displayed in a particular order (this was most important in "Team").
What was the hardest part of this assignment, and why was it difficult Just the sheer volume of memorization (of properties and possible values) that needs to happen is a big challenge.
What concept did you get the most clarity on through Startrly? I started working with CSS and HTML 20 years ago (although I haven't done much in the past few years) and was glad to learn new and exciting things! Flexbox and Grid are totally new to me and I'm glad there are now better things for layout than tables and frames and absolute positioning. Semantic HTML is also a thing that makes a lot of sense, and I'm glad to know about it.

Copy link

@goblineer goblineer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular implementation! Gold stars galore.
I had trouble setting up my review, so let's talk out loud since that will be a better use of time.

</head>
<body>
<div>
<div class="container">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, whole page in a container -- maybe a good place for a huuuuge grid to help with layout (with which you don't need more help, as your layout looks pixel-perfect). Do you style this class anywhere?

<section id="footer">
<div>
<h3>Support</h3>
<ul>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HTML is changed only to add ids. Nicely done! ID rather than class is a choice toward specificity but doesn't allow reusing styling in a flexible way. Are there areas where you wrote the same CSS for two different ids?

padding: 0px;
display: inline-grid;
grid-template: 250px 250px / 20% 20% 20% 20% 20%;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice template! The absolute values for each cell's size are preventing the resizing you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants