Conversation
bonara
left a comment
bonara
left a comment
There was a problem hiding this comment.
Great job! I like how you used both grid and flex box evenly through your code. Your selectors were very specific! Maybe we can DRY up the code little bit? For instance, adding list-style: none to ul element will allow you to remove it from the specific lists.
| /* border: solid; */ | ||
| grid-column-start: 3; | ||
| grid-row-start: 2; | ||
| } |
There was a problem hiding this comment.
Great job! I like how you used grid here and nth-of-type selector. I noticed that you had 2 rows and only second one was used. Was it intentional?
| width: 100%; | ||
| padding-top: 3%; | ||
| padding-bottom: 3%; | ||
| } |
There was a problem hiding this comment.
I like how your selectors are very specific which might be great if html changes in the future. However, if you are applying the same style to all h2 elements, it might be good to just target h2 element.
bonara
left a comment
bonara
left a comment
There was a problem hiding this comment.
Great job! I like how you used both grid and flex box evenly through your code. Your selectors were very specific! Maybe we can DRY up the code little bit? For instance, adding list-style: none to ul element will allow you to remove it from the specific lists. Overall your page looks great :)
| #sponsors ul li { | ||
| margin-left: 5px; | ||
| margin-right: 5px; | ||
| /* width: 25%; */ |
There was a problem hiding this comment.
Great use of flex boxes for the team and sponsors elements!
| } | ||
| #footer ul li{ | ||
| /* background-color: yellow; */ | ||
| /* text-align: left; */ |
There was a problem hiding this comment.
Your footer looks really nice! Again, great use of grid :)
| } | ||
| #team li span{ | ||
| /* border: solid; */ | ||
| text-align: center; |
There was a problem hiding this comment.
It's really cool how you implemented grid inside the flex box! I learned something new :)
| grid-row-start: 2; | ||
| } | ||
| .quote p::before { | ||
| content: "--"; |
| height: 15em; | ||
| display: grid; | ||
| grid-template: 1fr 1fr 1fr 1fr / 1fr 5fr 1.5fr .5fr; | ||
| font-style: italic; |
There was a problem hiding this comment.
Your quote is aligned really nicely! I like how you used Grid here!
| font-size: 1.9vw; | ||
| overflow-wrap: break-word; | ||
| position: static; | ||
| line-height: normal; |
There was a problem hiding this comment.
I like how you used vw in your font-size instead of px!
2 participants
;
'
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions