Skip to content

Conversation

@tatsqui
Copy link

@tatsqui tatsqui commented Apr 5, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar They both allow you to modify/align content.
Give one example where you choose Flexbox over Grid I chose flex for the meet-team section because it was more responsive to screen size changes.
Where did you choose to use CSS Grid and why did you make that decision the nav bar because it was easier to move the items around.
What was the hardest part of this assignment, and why was it difficult I did not find the process very intuitive - moving items around.
What concept did you get the most clarity on through Startrly? How to create columns/rows and assign items to them in grid.

Copy link

@jillirami jillirami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your use of flex and grid throughout your code is logical and organized, I've learned a lot from it. Such a great job!!


/* nav bar has three columns */
nav ul {
display: grid;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your nav menu scales, and is fixed! This is awesome!

margin-right: 5%
}

blockquote {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to add quotations to this section by incorporating something like:

blockquote:before {
content: open-quote;
}

blockquote:after {
content: close-quote;
}


}

/* align quotes to center and author to bottom right */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your comments are incredibly helpful for my understanding of your code! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants