Conversation
msfinnan
left a comment
There was a problem hiding this comment.
This looks wonderful, Maria!! Your code is super clear and easy to read :) I think you could consider using a different size element than pixel to make the page more responsive to smaller windows. Your webpage looks really profession and is really close to the wireframe! Great job!
|
|
||
| /* Main wrapper grid */ | ||
|
|
||
| .wrapper { |
There was a problem hiding this comment.
Good use of descriptive class names. It makes it very clear which section the CSS is for.
| padding-left: 50px; | ||
| margin: 0; | ||
| padding-right: 50px; | ||
| grid-template-areas: |
| "footer"; | ||
| } | ||
|
|
||
| .wrapper > *:not(.content-why):not(.content-sponsors) { |
There was a problem hiding this comment.
This is an interesting line of code! What does the * do?
| grid-area: footer; | ||
| } | ||
|
|
||
| /* nav */ |
There was a problem hiding this comment.
The comments you add before each section makes the code very readable.
| padding-bottom: 30px; | ||
| } | ||
|
|
||
| /* content-team */ |
There was a problem hiding this comment.
In this section, it might be helpful to use a Flexbox to get the text lined up under the images. A TA helped me with this section and we got it to work by making the unordered list (ul) a Flexbox with flex-direction: row and the list items (li) a Flexbox with flex-direction: column.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions