Skip to content

Sockets - Maria #37

Open
MariaWissler wants to merge 3 commits intoAda-C11:masterfrom
MariaWissler:master
Open

Sockets - Maria #37
MariaWissler wants to merge 3 commits intoAda-C11:masterfrom
MariaWissler:master

Conversation

@MariaWissler
Copy link

@MariaWissler MariaWissler commented Apr 5, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar They both allow rendering space, shape manipulation
Give one example where you choose Flexbox over Grid used flexbox to bring up the quotes as it seems to highlighted more and grid to accommodate the team images
Where did you choose to use CSS Grid and why did you make that decision Team images section
What was the hardest part of this assignment, and why was it difficult Many things, getting familiar with html, spacing, centering, and have a sense of the space and distribution
What concept did you get the most clarity on through Startrly? html tags and distribution, still working on the styling

Copy link

@msfinnan msfinnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wonderful, Maria!! Your code is super clear and easy to read :) I think you could consider using a different size element than pixel to make the page more responsive to smaller windows. Your webpage looks really profession and is really close to the wireframe! Great job!


/* Main wrapper grid */

.wrapper {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of descriptive class names. It makes it very clear which section the CSS is for.

padding-left: 50px;
margin: 0;
padding-right: 50px;
grid-template-areas:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good overall structure of the page :)

"footer";
}

.wrapper > *:not(.content-why):not(.content-sponsors) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting line of code! What does the * do?

grid-area: footer;
}

/* nav */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments you add before each section makes the code very readable.

padding-bottom: 30px;
}

/* content-team */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this section, it might be helpful to use a Flexbox to get the text lined up under the images. A TA helped me with this section and we got it to work by making the unordered list (ul) a Flexbox with flex-direction: row and the list items (li) a Flexbox with flex-direction: column.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants