Skip to content

Ports-Elise#38

Open
ChubbyCub wants to merge 8 commits intoAda-C11:masterfrom
ChubbyCub:master
Open

Ports-Elise#38
ChubbyCub wants to merge 8 commits intoAda-C11:masterfrom
ChubbyCub:master

Conversation

@ChubbyCub
Copy link

@ChubbyCub ChubbyCub commented Apr 5, 2019

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar They both put the items inside the parent container into boxes.
Give one example where you choose Flexbox over Grid Flexbox is useful for single dimension layouts, while Grid is more useful for two-dimensional layouts.
Where did you choose to use CSS Grid and why did you make that decision I used a grid for team member section because I want to group 3 elements on the first row and 2 elements on the second row.
What was the hardest part of this assignment, and why was it difficult The hardest part for this assignment was to get the elements to align.
What concept did you get the most clarity on through Startrly? I gained a better understanding of grid layout


<nav>
<ul>
<nav class="nav-bar">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of these classes. I think you did a great job of choosing descriptive names.

@@ -0,0 +1,349 @@
/*! normalize.css v8.0.1 | MIT License | github.com/necolas/normalize.css */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job adding a normalize file!

background-color: lightgoldenrodyellow
}

.nav-bar-list {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great and follows the wireframe.


.container {
max-width: auto;
display: grid;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make sure your webpage more responsive to changes, you could try removing the grid display from the container. (I played with this, and removing grid display from your container causes some other unintended changes (that should be easily fixable), but be aware of that!)

}

a:hover {
font-weight: bold;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! It really drives attention to the link

}

#quote {
margin-left: 10px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using rem or em here like you do other places would help making your webpage even more accessible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants