-
Notifications
You must be signed in to change notification settings - Fork 48
Sockets - Sarah #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Sockets - Sarah #41
Conversation
dev-elle-up
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! I love the colors and the style overall. Also your code is dry and easy to read. Great work.
| } | ||
| .tagline { | ||
| background: #57BC90; | ||
| display: grid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of grid on the tagline section!
| @@ -0,0 +1,149 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider using grid for the overall structure?
| } | ||
|
|
||
| .flexbox li { | ||
| flex: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I hadn't seen before. Thanks for the learning moment. :-)
| } | ||
|
|
||
| .sponsers .flexbox, .team-members .flexbox { | ||
| justify-content: space-around; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sponsors are almost touching on my browser. Was this a design choice or a browser rendering? It could be nice to give these elements a little margin. (or not)
| flex-direction: column; | ||
| } | ||
|
|
||
| .team-members .flexbox li img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you did a great job of naming everything! It made it very easy to read your code.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions