Sockets - Kate N #44
Open
Sockets - Kate N #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandria7
reviewed
Apr 5, 2019
alexandria7
left a comment
alexandria7
left a comment
There was a problem hiding this comment.
Kate great work!!! I love your overall organization using CSS grid and think your code is pretty DRY :)
| width: 100%; | ||
| height: 90%; | ||
| display: grid; | ||
| grid-template: auto auto / auto auto auto auto auto auto; |
| </blockquote> | ||
| <p> | ||
| Mx. Ipsum | ||
| -- Mx. Ipsum |
There was a problem hiding this comment.
I think there is a way to add a "--" in css instead of changing the html directly! I would try using the pseudo-class ":before" with "content: '--'"
|
|
||
| section.sponsors ul { | ||
| display: grid; | ||
| grid-template: auto auto / auto auto auto auto; |
There was a problem hiding this comment.
I really love your use of grid in this section! It organizes all of the list items in the configuration you want and doesn't allow for things to move out of place!
| height: 40%; | ||
| display: grid; | ||
| grid-template: auto auto 40% / auto; | ||
| justify-items: center; |
There was a problem hiding this comment.
Does "justify-items" work without "display: flex"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions