Sockets - Maria

[MariaWissler]

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	It allows multiple things to happen at the same time. When you start an action, your program continues to run.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	We use axios to make AJAX requests which are asynchronous, I used the invisible addClass and removeClass for trip details and booking so they show once a user selects a trip from the main list
What kind of errors might the API give you? How did you choose to handle them?	400 errors , I didnt parse my errors but still display an alert
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.	I think having the list sorted makes the search faster but we still have the Id available to find it

[dHelmgren]

This tacks on reservations, so each time you try to reserve a spot, the URL gets longer.

ie URL on first click= https://trektravel.herokuapp.com/trips/##/reservations/
on second= https://trektravel.herokuapp.com/trips/##/reservations/

[dHelmgren]

I'd hope not!

[dHelmgren]

The formatting here is kind of wonky

[dHelmgren]

You're putting the current trip ID in this global scope in order to store what the current trip is... You should consider different approaches to get the value of the current trip id. Could you use a closure or read from the HTML with event delegation?

Also, we use let, not var!

[dHelmgren]

These error messages don't tell us anything about what is going wrong with this request. You're not making an effort to describe in detail what the user needs to do to continue properly.

[dHelmgren]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	good
Comprehension questions
Functionality
Click a button to load and view a list of trips	yes
Clicking the "load" button twice does not cause each trip to display twice	yes
Click a trip to load and view trip details	yes
Clicking a different trip loads different details	yes
Open network tab, then fill out a form to reserve a spot	yes, but see comment.
Submitting the form only sends one POST request	yes
Errors are reported to the user	not really, see comments
Site is clearly laid out and easy to navigate	yes
Under the Hood
Callback functions are not nested more than 2 levels deep	yes
Callback functions are given descriptive names	yes
Code is generally well-organized and easy to read	yes
All API calls have both success and error callbacks defined	yes
Optional but recommended: closures are used to keep track of which trip is selected	no
HTML is semantic	No
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap	yes
Overall	Great job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I've left a couple inline comments for you to review below, but in general I am quite happy with this submission. Keep up the hard work!