Ports - Kasey

[kaseea]

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What does it mean for code to be asynchronous?	a process starts, and instead of waiting for a response, keeps moving, and gets the response some time later.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it?	axios.get executes asynchronously, which returns a promise, which state's TBD, meaning I put code I wanted to execute after .then?
What kind of errors might the API give you? How did you choose to handle them?	By using axios-pets error handling.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not.	I doubt it, unless we're suppose to implement our (binary) search for it, but imagine something like JS's find method should be fine, also, if its routinely done I'm hoping whatever we run our site on does a good job of caching that information, which would be better than anything I could do? I really don't know.

[kaidamasaki]

TREK

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	👍🏼
Comprehension questions	👍🏼 (Though you forgot to mention what kinds of errors you could get.)
Functionality
Click a button to load and view a list of trips	👍🏼
Clicking the "load" button twice does not cause each trip to display twice	👍🏼
Click a trip to load and view trip details	👍🏼
Clicking a different trip loads different details	👍🏼
Open network tab, then fill out a form to reserve a spot	👎🏼 (incorrect path; missing /trips/ before the ID.)
Submitting the form only sends one POST request	👍🏼
Errors are reported to the user	👎🏼 (You build errorHtml but then don't display it to the user.)
Site is clearly laid out and easy to navigate	👍🏼
Under the Hood
Callback functions are not nested more than 2 levels deep	👍🏼
Callback functions are given descriptive names	👍🏼
Code is generally well-organized and easy to read	👍🏼 (though some of your indentation is a little weird.)
All API calls have both success and error callbacks defined	👍🏼
Optional but recommended: closures are used to keep track of which trip is selected	👍🏼
HTML is semantic	Mostly. There are some pieces of weirdness like not using <label>s for <input>s.
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap	👍🏼 (Bootstrap)
Overall	While you had some trouble submitting a reservation this is overall a pretty reasonable solution.

[kaidamasaki]

I'm worried this came across as a little harsh, I submitted feedback as I was running out the door.

This was a good solution, just a bit messy and with a couple of small bugs.