Skip to content

Sockets - Erica#30

Open
norrise120 wants to merge 11 commits intoAda-C11:masterfrom
norrise120:master
Open

Sockets - Erica#30
norrise120 wants to merge 11 commits intoAda-C11:masterfrom
norrise120:master

Conversation

@norrise120
Copy link

@norrise120 norrise120 commented Jun 3, 2019

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that the code doesn't all run, in order. In other words, the several functions can run while the page is still loading.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? I believe my loadTrekDetails and submitReservation run asynchronously.
What kind of errors might the API give you? How did you choose to handle them? I handle them like we have been in class. One error that I did receive while working on this project is "404" because I had my individual trip url formatted incorrectly.
Suppose you needed to routinely find a specific Trip in the list by its ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. I think that the order is unnecessary as the program is smart enough to know what thing is clicked (assuming the programmer is smart enough to set it up correctly).

PS: Passing functions as parameters into other functions is sooo cool!

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene
Comprehension questions
Functionality
Click a button to load and view a list of trips yes
Clicking the "load" button twice does not cause each trip to display twice yes
Click a trip to load and view trip details yes, but you add a new section for reserving your spot each time
Clicking a different trip loads different details yes
Open network tab, then fill out a form to reserve a spot yes
Submitting the form only sends one POST request yes
Errors are reported to the user yes, but you don't go into details, which would be better.
Site is clearly laid out and easy to navigate yes
Under the Hood
Callback functions are not nested more than 2 levels deep yes
Callback functions are given descriptive names yes
Code is generally well-organized and easy to read yes
All API calls have both success and error callbacks defined yes
Optional but recommended: closures are used to keep track of which trip is selected no
HTML is semantic yes
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap yes
Overall Great job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I've left a couple inline comments for you to review below, but in general I am quite happy with this submission. Keep up the hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants