Skip to content

Ports - Cloudy#40

Open
CloudyLopez wants to merge 1 commit intoAda-C11:masterfrom
CloudyLopez:master
Open

Ports - Cloudy#40
CloudyLopez wants to merge 1 commit intoAda-C11:masterfrom
CloudyLopez:master

Conversation

@CloudyLopez
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? asynchronous code is code that moves and grooves at the same time as other things are happening at the same time.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? the API allows the code to move asynchronously so there wasn't any concern on my end on the structure of it.
What kind of errors might the API give you? How did you choose to handle them? status errors are the kind of errors one would get if the API failed .
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. it would not matter as its calling it by id and we've already accounted for that.

@CheezItMan
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Only ONE commit! Doh!
Comprehension questions Check
Functionality
Click a button to load and view a list of trips Check
Clicking the "load" button twice does not cause each trip to display twice Check
Click a trip to load and view trip details Check
Clicking a different trip loads different details Check
Open network tab, then fill out a form to reserve a spot No way to reserve a spot.
Submitting the form only sends one POST request MISSING
Errors are reported to the user Nope, no errors are visible
Site is clearly laid out and easy to navigate plain with minimal styling
Under the Hood
Callback functions are not nested more than 2 levels deep Check
Callback functions are given descriptive names Check
Code is generally well-organized and easy to read Check
All API calls have both success and error callbacks defined Check
HTML is semantic Your button element is not in container elements, same with the input (and no form element either).
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap
Overall You hit the learning goals for waves 1 & 2. You don't have the registering for trips done yet so you are missing the learning goals for making post requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants