Skip to content

Conversation

@carlabosco
Copy link

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? It means that the page will not necessarily load in the same order as the code.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Expanding details for a trip and displaying the reservation form will only load after a trip is selected.
What kind of errors might the API give you? How did you choose to handle them? An invalid trip id will not return details for that destination. I handled errors with catch blocks.
Suppose you needed to routinely find a specific Trip in the list by it's ID field. Would it be advantageous to keep the list in order by the id field? Explain why or why not. I believe it would. If I could perform binary search on an ordered list this could help retrieve the trip faster.

@dHelmgren
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to load and view a list of trips yes
Clicking the "load" button twice does not cause each trip to display twice yes
Click a trip to load and view trip details yes
Clicking a different trip loads different details yes
Open network tab, then fill out a form to reserve a spot yes
Submitting the form only sends one POST request yes
Errors are reported to the user no, you are updating an element, but it's not displaying.
Site is clearly laid out and easy to navigate yes
Under the Hood
Callback functions are not nested more than 2 levels deep yes
Callback functions are given descriptive names yes
Code is generally well-organized and easy to read yes
All API calls have both success and error callbacks defined yes
Optional but recommended: closures are used to keep track of which trip is selected no
HTML is semantic yes
CSS is DRY, uses CSS Grid, Flexbox, and/or Bootstrap yes
Overall Excellent job overall! This code is for the most part well-organized and easy to read, and it's clear the learning goals of this assignment were met. I've left a couple inline comments for you to review below, but in general I am quite happy with this submission. Keep up the hard work!

// Status Management
//
const reportStatus = (message) => {
$('#status-message').html(message).fadeOut(5000);;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fadeOut doesn't reset the style on the element, so after the first time it's faded all the way out, the box never appears again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants