Leaves - Kristina and Julia by Kalakalot · Pull Request #15 · Ada-C12/adagrams

Kalakalot · 2019-08-15T22:17:06Z

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature	Feedback
What are the components that make up a method?	the signature, the parameter(s), and if you're calling a method, the arguments
What are the advantages of using git when collaboratively working on one code base?	Git provides version control and allows you to add notes when you are making changes, which is helpful for your team members (and yourself). Git also shows who made which changes, and provides ability to compare differences.
What kind of relationship did you and your pair have with the unit tests?	A challenging one: it took us a while to figure out how the tests fit with our code and the driver code, but once we understood, tests made finding errors and pinpointing what was wrong much easier.
Does your code use any methods from the `Enumerable` mixin? If so, where and why was it helpful?	We successfully used .max to find the highest-scoring word. We tried to implement .select to help us with tie-breaking for equally scoring words (wave 4), but we ran out of time and brainpower.
What was one method you and your pair used to debug code?	We used the errors and stack trace from tests to determine where errors in our code originated.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We talked about learning styles (very similar) and we also checked in about emotions frequently, which helped us understand where the other person was coming from. We bonded over lack of sleep and bad but funny jokes.

…d it

…c, and moving return statement

…hy the code wasn't working.

…mitting project now.

dHelmgren · 2019-08-20T21:58:21Z

Adagrams

What We're Looking For

Feature	Feedback
General
Answered comprehension questions	Yes
Small commits with meaningful commit messages	yes
Code Requirements
`draw_letters` method
Uses appropriate data structure to store the letter distribution	yes, but see comments
All tests for `draw_letters` pass	yes
`uses_available_letters?` method
All tests for `uses_available_letters?` pass	yes
`score_word` method
Uses appropriate data structure to store the letter scores	yes
All tests for `score_word` pass	No, see comments.
`highest_score_from` method
Appropriately handles edge cases for tie-breaking logic	yes
All tests for `highest_score_from` pass	yes
Overall	Good work on this, though some of your tests are failing. I left a few comments around this code. Your process right now is solid, and has gotten you to many correct answers. However, you end up repeating your work a bunch, or doing things with more lines of code than you need. Checking in with the documentation to find just the right method is a really clutch skill that can sometimes save hours of work. As we progress in the curriculum, focus on making sure your fundamentals are sharp, and that you check and recheck your mental toolbox for the right built-in tools.

dHelmgren · 2019-08-20T21:42:54Z

adagrams.rb

+  letters_in_hand = []
+
+  10.times do |letter|
+    letter = remaining_pool.sample


There is another version of sample! It might help you DRY up this code.

dHelmgren · 2019-08-20T21:43:17Z

adagrams.rb

+
+# Wave one method
+def draw_letters
+  remaining_pool = %w(a a a a a a a a a b b c c d d d d e e e e e e e e e e e e f f g g g h h i i i i i i i i i j k l l l l m m n n n n n n o o o o o o o o p p q r r r r r r s s s s t t t t t t u u u u v v w w x y y z)


Why do we redo the work of line 3 here?

dHelmgren · 2019-08-20T21:43:58Z

adagrams.rb

+
+
+# Wave 2: uses_available_letters?
+# Need to review lines 57-67, b/c failing test for returning true if the submitted letters are valid against the drawn letters


This comment should come out before submission!

dHelmgren · 2019-08-20T21:45:29Z

adagrams.rb

+
+  input_array.each do |letter|
+    unless letters_in_hand.include?(letter) 
+      return false


You end up repeating this work down below.

dHelmgren · 2019-08-20T21:47:35Z

adagrams.rb

+
+  # making a hash from user_input with letters as keys and counts as values 
+  input_hash = {}
+  input_array.each do |letter|


I think making a second hash complicates this a lot. What if you just used the input string to count down the number of letters from letters_hand_hash?

dHelmgren · 2019-08-20T21:49:36Z

adagrams.rb

+  end 
+
+  # If the length of word is between 7-10, add 8 points to the total score 
+  if input_array.length == 7 || input_array.length == 8 || input_array.length == 9 || input_array.length == 10


You can reduce the amount of work you are doing here! It's possible to do this line with only 2 comparisons. What are they?

Details
if input_array.length >= 7 && input_array.length <= 10

dHelmgren · 2019-08-20T21:50:36Z

adagrams.rb

+  # Calculating the sum for all the letters in word 
+  sum = 0
+  scores.each do |score|
+    sum = sum + score


If you're trying to end up with a sum, why make an array and then convert that array into a bunch of letters? You can just add up all the letter scores as you go!

dHelmgren · 2019-08-20T21:51:40Z

adagrams.rb

+
+  words.each do |word|
+    word_letters = word.chars #convert string to array of characters
+    word_length = word_letters.length #count the length of characters 


You added a step here. word.length is a valid string operation!

dHelmgren · 2019-08-20T21:53:25Z

adagrams.rb

+
+  # determine which word has the highest score and return associated word
+  highest_score = word_scores.max
+


You currently have 2 failing tests. The code that will fix them goes here. You need to either 1) prefer the shortest word or 2) prefer the word that uses all 10 letters, depending on input.

dHelmgren · 2019-08-20T21:53:55Z

lib/adagrams.rb

@@ -0,0 +1,174 @@
+require 'pry'
+
+letter_pool = %w(a a a a a a a a a b b c c d d d d e e e e e e e e e e e e f f g g g h h i i i i i i i i i j k l l l l m m n n n n n n o o o o o o o o p p q r r r r r r s s s s t t t t t t u u u u v v w w x y y z)


looks like you have two versions of this file. was that intentional?

Julia Kingrey and others added 16 commits August 12, 2019 16:23

Working code w/o method created for wave 1

4b25a09

Added note w/code sample for upcasing letter pool

8bdd4b6

moved adagrams.rb into lib folder and deleted duplicated version

74eb6b1

Added code that turns user input string into array of characters

54e2ee2

added code to compare letters in hand to letters in word

f0eb788

can't remember what was changed here

2047e72

adding .gitignore fie with secrets.rb

2c659ed

ran into frustration with wave 2, passed wave 3, working on wave 4

28dd095

made a change to driver code but realized that was a no-no and remove…

3dbf312

…d it

fixed one of two wave 2 errors (variable name error)

95397f5

Wave 2 tests now passing after updating variable name, reversing logi…

973e4a8

…c, and moving return statement

Added notes about the changes Julia made so Kristina can understand w…

2a77b2a

…hy the code wasn't working.

legit passing two wave 4 tests, can't get the rest. Brains tired. Sub…

7946672

…mitting project now.

Create Leaves - Kristina and Julia K

0ba2160

Rename Leaves - Kristina and Julia K to adagrams.rb

c907441

Merge branch 'master' of https://github.com/Kalakalot/adagrams

9a3bf38

dHelmgren reviewed Aug 20, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Leaves - Kristina and Julia#15

Leaves - Kristina and Julia#15
Kalakalot wants to merge 16 commits intoAda-C12:masterfrom
Kalakalot:master

Kalakalot commented Aug 15, 2019

Uh oh!

dHelmgren commented Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

dHelmgren Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants



		# Wave 2: uses_available_letters?
		# Need to review lines 57-67, b/c failing test for returning true if the submitted letters are valid against the drawn letters


		# determine which word has the highest score and return associated word
		highest_score = word_scores.max

		@@ -0,0 +1,174 @@
		require 'pry'

		letter_pool = %w(a a a a a a a a a b b c c d d d d e e e e e e e e e e e e f f g g g h h i i i i i i i i i j k l l l l m m n n n n n n o o o o o o o o p p q r r r r r r s s s s t t t t t t u u u u v v w w x y y z)

Comments

Conversation

Kalakalot commented Aug 15, 2019

Adagrams

Comprehension Questions

Uh oh!

dHelmgren commented Aug 20, 2019

Adagrams

What We're Looking For

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants