Leaves - Natalie Tapias #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod to make the test pass.
…nd method. Still working on it but saving my work here.
…dle negative numbers yet). Added a large number test and modified the method to make it pass.
CheezItMan
reviewed
Sep 3, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work, you hit all the learning goals here! Well done.
| until num == 0 | ||
| modulo = (num % 2).to_s | ||
| num /= 2 | ||
| binary_number = modulo+binary_number |
There was a problem hiding this comment.
Clever use of string concatenation to reverse things.
| def binary_to_decimal(binary_array) | ||
| raise NotImplementedError | ||
| decimal = 0 | ||
| exponent = 7 |
There was a problem hiding this comment.
Minor: I suggest making 7 a constant or binary_array.length - 1 to avoid hardcoding in specific numbers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary and Decimal
Congratulations! You're submitting your assignment.