Skip to content

Leaves - Samantha #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamsammysam wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Leaves - Samantha #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/binary_to_decimal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@
# The array is randomly filled with 0’s and 1’s.
# The most significant bit is at index 0.
# The least significant bit is at index 7.
# Calculate and return the decimal value for this binary number using
# the algorithm you devised in class.
def binary_to_decimal(binary_array)
raise NotImplementedError
# Calculate and return the decimal value for this binary number using the algorithm you devised in class.

def binary_to_decimal(binary_array)
decimal_num = 0
binary_array.each_with_index do |bit_num, i|
if bit_num == 1
decimal_num += 2**(7-i)
Copy link

@CheezItMan CheezItMan Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using a constant or binary_array.length -1 in place of 7. That just makes the code a bit more flexible.

end
end
return decimal_num
end