Pr 5 #5
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
|
|
||
| const isAllUniqueElements = (array) => { | ||
|
There was a problem hiding this comment. Could we rename to areAllElementsUnique? Might read a little more smoothly ... |
||
| let isAllUnique = true; | ||
|
|
||
| array.forEach((currentElement, currentIndex) => { | ||
|
There was a problem hiding this comment. good function to check for unique elements |
||
| array.slice(currentIndex + 1).forEach((elementToCompare) => { | ||
|
There was a problem hiding this comment. Consider limiting the number of loops within loops to improve time efficiency |
||
| if (elementToCompare === currentElement) { | ||
| isAllUnique = false; | ||
|
There was a problem hiding this comment. I feel like we should be returning isAllUnique right away if it is false so that the code doesn't have to continue through the entire array before returning. There was a problem hiding this comment. You may want to consider exiting loop if isAllUnique==false. Otherwise, it will loop through the whole array. There was a problem hiding this comment. Returns true for empty array -- should it return null instead? There was a problem hiding this comment. If you add a return as soon as you find a duplicate, it will be more efficient because it won't have to keep searching through the rest of the array There was a problem hiding this comment. We can add a return if isAllUnique = false instead to make the program run more efficiently There was a problem hiding this comment. Can we refactor to exit the loop as soon as it is false? |
||
| } | ||
| }); | ||
| }); | ||
|
|
||
| return isAllUnique; | ||
| }; | ||
|
|
||
|
|
||
| export default isAllUniqueElements; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment to describe what type of uniqueness you are looking for (unique characters? unique array items?)