PR #7 #7
Open
PR #7 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfunkemomo
reviewed
Feb 6, 2020
| printList() { | ||
| let current = this; | ||
|
|
||
| while (current != null) { |
llinneaa
reviewed
Feb 6, 2020
| } | ||
| } | ||
| } | ||
|
|
| } | ||
| } | ||
|
|
||
| export default Node; No newline at end of file |
geli-gel
approved these changes
Feb 6, 2020
geli-gel
left a comment
geli-gel
left a comment
There was a problem hiding this comment.
You can set your code editor (probably) to automatically add newlines at the end to match style guidelines ... or is that just ruby???
| this.value = value; | ||
| this.next = next; | ||
| } | ||
|
|
|
|
||
| setNext(next) { | ||
| this.next = next; | ||
| } |
There was a problem hiding this comment.
should this explicitly return something?
| } | ||
| } | ||
|
|
||
| export default Node; No newline at end of file |
Kalakalot
reviewed
Feb 6, 2020
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Clear and appreciate the descriptive function names
calopter
reviewed
Feb 6, 2020
| let current = this; | ||
|
|
||
| while (current != null) { | ||
| console.log(current.value); |
There was a problem hiding this comment.
using .getValue() might honor encapsulation more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.