Leaves - Tiffany by TiffanyChio · Pull Request #25 · Ada-C12/hotel

TiffanyChio · 2019-09-09T05:18:25Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	I feel that up until now, the focus has been on code readability, even if it requires sacrificing memory efficiency or time efficiency. With this project the focus may have flipped?
What was a design decision you made that changed over time over the project?	I included a Date class in my design and it became the core of my code. However it appears to be not entirely necessary. I could have relied more heavily on iterating through my list of reservations to get the information that I needed. By the time, I realized this it was too late to change the code without starting over from scratch because of how central the Date class was to my code. However I still like the design. I think it is intuitive and readable.
What was a concept you gained clarity on, or a learning that you'd like to share?	I initially called Dates HotelDates. But modules are namespaces and I wanted to use the Hotel module appropriately. It was still causing conflicts with Ruby's built-in Date class. Chris recommended using ::Date, which does not specify a module and Ruby was able to differentiate between the two classes.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	Reservations do not impact list of available rooms outside of date range. The dates are no where near overlap in this case.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	Reservations can be made if the check-in date is overlaps with the check-out date of another reservation for the same room. This is an edge case because there is an overlap in dates though rooms are available for check-in on the same day as another check-out.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	I pseudocoded my tests first and then wrote my code. I did it but I definitely did not enjoy it. Writing tests after writing the code feels more intuitive to me. It would also help me better create edge cases to test.

…tions overall. Created and passed all reservation initialization tests.

… passed for that item.

…lect changes to fix bugs.

…verlap yet.

…ystem.rb

…elblocks. not done yet.

…eation in sys.

…nputs to date object inputs.

…nclature...

beccaelenzil · 2019-09-11T18:12:18Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	100% !
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	100% !
Wave 3
Create a block of rooms	yes
Check if a block has rooms	yes
Reserve a room from a block	yes
Test coverage	100% !

Code Review

Baseline	Feedback
Used git regularly	yes
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes -- nice work on this front
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself! In particular nice work implementing Wave 3. Your use of inheritance for HotelBlock and the change_status method are quite clever.

beccaelenzil · 2019-09-11T17:58:55Z

lib/custom_errors.rb

@@ -0,0 +1,2 @@
+class FullOccupancyError < StandardError


This is a great example of defining your own appropriately named exception type.

beccaelenzil · 2019-09-11T18:00:28Z

lib/hoteldate.rb

+
+    # Returns only reservations and not hotel blocks as per specs.
+    def list_reservations
+      return @occupied.values.select { |value| value.class == Hotel::Reservation }


Ruby will be looking for names locally first, prioritizing local names, since they're all in the same module, there's no need to namespace Hotel::Reservation. Reservation should just work! Same with the rest of the namespacing in the code.

beccaelenzil · 2019-09-11T18:01:08Z

lib/hoteldate.rb

+
+    # Returns only reservations and not hotel blocks as per specs.
+    def list_reservations
+      return @occupied.values.select { |value| value.class == Hotel::Reservation }


clever use of select!

beccaelenzil · 2019-09-11T18:01:28Z

lib/hotelblock.rb

+require_relative 'reservation'
+
+module Hotel
+  class HotelBlock < Reservation


Great use of inheritance.

beccaelenzil · 2019-09-11T18:02:34Z

lib/system.rb

+    attr_reader :rooms, :reservations, :dates, :hotelblocks
+
+    def initialize
+      @rooms = Hotel::Room.generate_rooms


Nice use of a class method.

beccaelenzil · 2019-09-11T18:04:20Z

lib/system.rb

+    def initialize
+      @rooms = Hotel::Room.generate_rooms
+      @reservations = []
+      @dates = []


A comment to tell us what @dates is meant to hold would be useful, as it's not immediately obvious.

beccaelenzil · 2019-09-11T18:06:41Z

test/system_test.rb

+      expect(@first_res).must_be_instance_of Hotel::Reservation
+
+      expect(@first_res.id).must_equal 1
+      expect(@first_res.start_date).must_equal ::Date.parse('2019-06-05')


Consider assigning dates to variables in your tests to make it clear what you are testing.

Suggested change

expect(@first_res.start_date).must_equal ::Date.parse('2019-06-05')

start_date = Date.parse('2019-06-05')

end_date = start_date + 3

TiffanyChio added 30 commits September 3, 2019 13:09

Created all the lib files. No content yet.

ffd84bd

Created Room class. All it does is initialize Rooms

45c3a5c

Added simple cov and lib files to test_helper.

b3cf64e

Created test for room.rb (initiation). Everything passes.

5e39d57

Created initialize and helper methods for reservations. Untested.

b320079

Fixed multi use of Date name in reservations variables. Fixed reserva…

783424f

…tions overall. Created and passed all reservation initialization tests.

added argument error checks for start and end date. Tests created and…

092ea03

… passed for that item.

Minor fix to total_cost in reservation.rb

023e763

added HotelDate class. No tests have been added or processed yet.

00455f0

added HotelDate test file. All tests passed. HotelDate editted to ref…

2f10378

…lect changes to fix bugs.

added make reservation method for system.rb

f09ba52

Removed date range from reservation class and all tests still pass.

42df5a2

Tested make reservation method in system. Works great. Haven't done o…

f0c6e82

…verlap yet.

Added tests for methods of hoteldate. find available room works for s…

15f2043

…ystem.rb

Completed all tests for wave 2. Everything passes.

86b7cdb

Changed Reservation instantiation from total cost to cost)

df40439

moved room generation from system to room class. started creating hot…

4e6f127

…elblocks. not done yet.

tested hotelblock.rb and it passes. Still need to tweak hotelblock cr…

fa6ab8b

…eation in sys.

tested hotel block creation, appears to be working fine.

48918bf

last working code before we change hbs list over to hash

67dbe11

changed hotel blocks list over to hash. tests are still passing.

76486fe

Completed wave 3. All tests pass

bafa5ed

changed hoteldate logic to reflect both reservations and hotel blocks.

b9b6026

save before changing hoteldate to date

1c841a9

refactoring system.rb changed all the make reservations from string i…

dc88859

…nputs to date object inputs.

refactoring system.rb about to change list reservations over to objects

746d394

complete refactor of system.rb

18f55d2

last working commit before trying to change namespaces again

5a4a8e4

tentatively saving. nothing broke after changing hotelname class nome…

551edc3

…nclature...

refactored room, reservation, hotelblock test files

5e24692

TiffanyChio added 6 commits September 7, 2019 12:17

refactored all tests except for system

05dae1d

added edge cases

be55658

added hotel block testing

748f2e0

clean up comments

273e3cf

added refactor.txt file

9e6cbd3

added ideas to refactor.txt

25aa0fa

beccaelenzil reviewed Sep 11, 2019

View reviewed changes

TiffanyChio added 2 commits September 26, 2019 13:36

completed design_activity.md

5f1c7b3

made changes to more loosely couple objects in hotel

78862b7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leaves - Tiffany#25

Leaves - Tiffany#25
TiffanyChio wants to merge 38 commits intoAda-C12:masterfrom
TiffanyChio:master

TiffanyChio commented Sep 9, 2019

Uh oh!

beccaelenzil commented Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

beccaelenzil Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	expect(@first_res.start_date).must_equal ::Date.parse('2019-06-05')
	start_date = Date.parse('2019-06-05')
	end_date = start_date + 3

Conversation

TiffanyChio commented Sep 9, 2019

Hotel

Comprehension Questions

Uh oh!

beccaelenzil commented Sep 11, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

beccaelenzil Sep 11, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants