Leaves - Cloudy by OhCloud · Pull Request #29 · Ada-C12/hotel

OhCloud · 2019-09-09T05:47:51Z

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	The way that each class handled its responsibilities is something i put alot of emphasis to because the more clear cut the design, the better the code is, you know agile vs bufd but sometimes i think thats the better way to go for projects this size.
What was a design decision you made that changed over time over the project?	I went back and forth between few classes and lots of classes... alot. having decided what my uml looked like, what was gonna do what, i started. only to delete a class, and then add another class, and another.
What was a concept you gained clarity on, or a learning that you'd like to share?	the way the tests are was something that i think is sinking in. for testing - the way that the instance variables hold information and the way they are extracted is clear now and thats rad.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	a nominal test i wrote would be like reservation_test / instance of reservation. this is a nominal case bc we know this does create an instance of reservation.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	an edge case i wrote would be checking that checking out date cant happen before a check in date. we know this to be true bc time.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	i will make it a point to sudo-code more. I still cant break the habit of first writing the test and then writing the code. I will put more emphasis into this by doing lots of pseudocode.

…ze for date_range.rb and tests for date_range_tests.

…st, all passing, for it too.

…ses for it. boom boom.

…s. added a parameter to the hotel manager initalize to aid in this. added test for it. we good.

…dded date_of_res method too. test pass

…ve 2 complete

…t to couple

…, added tests, passing.

…ure that block.rb works properly. added create block and reserve from block methods. test are all passing. added caveat to block initialize to adhere to the 5 block room max. test pass for that too.

dHelmgren · 2019-09-15T23:21:13Z

Hotel

What We're Looking For

Test Inspection

Workflow	yes / yes but no test / no
Wave 1
List rooms	yes
Reserve a room for a given date range	yes
Reserve a room (edge case)	yes
List reservations for a given date	yes
Calculate reservation price	yes
Invalid date range produces an error	yes
Test coverage	Code coverage doesn't seem to be set up correctly, and indicates 30% coverage.
Wave 2
View available rooms for a given date range	yes
Reserving a room that is not available produces an error	yes
Test coverage	NA
Wave 3
Create a block of rooms	yes
Check if a block has rooms	yes
Reserve a room from a block	yes, but it's not explicitly tested!
Test coverage	yes

Code Review

Baseline	Feedback
Used git regularly	Yes, great commit comments!
Answer comprehension questions	yes
Design
Each class is responsible for a single piece of the program	yes
Classes are loosely coupled	yes
Fundamentals
Names variables, classes and modules appropriately	yes
Understanding of variable scope - local vs instance	yes
Can create complex logical structures utilizing variables	yes
Appropriately uses methods to break down tasks into smaller simpler tasks	yes
Understands the differences between class and instance methods	yes
Appropriately uses iterators and `Enumerable` methods	yes
Appropriately writes and utilizes classes	yes
Appropriately utilizes modules as a namespace	yes
Wrap Up
There is a refactors.txt file	yes
The file provides a roadmap to future changes	yes

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you broke down the problem with methods while keeping the code loosely coupled. There is nothing but trim, direct code here. This code kicks tons of butt, and you should be super proud!

I do see some room for improvement around editing your code to remove warnings. Also, don't forget to check your code coverage, it was including your tests, and therefore wasn't checking things properly. Your tests were thorough, but you need to prove it!

dHelmgren · 2019-09-15T22:51:10Z

test/block_test.rb

+    end
+
+    it "will raise an Argument Error if block requested is more than 5" do 
+      expect{block = Hotel::Block.new(@checkin_date, @checkout_date, 100, [4, 5, 6, 7, 8, 9])}.must_raise ArgumentError


block isn't used, threw an warning

dHelmgren · 2019-09-15T22:51:35Z

lib/date_range.rb

+require 'pry'
+require 'awesome_print'
+
+require_relative "../lib/reservation.rb"


circular require, warning

dHelmgren · 2019-09-15T22:52:18Z

lib/hotel_manager.rb

+require 'pry'
+require 'awesome_print'
+
+require_relative "../lib/date_range.rb"


circular require, warning

dHelmgren · 2019-09-15T22:52:39Z

lib/hotel_manager.rb

+require 'awesome_print'
+
+require_relative "../lib/date_range.rb"
+require_relative "../lib/hotel_manager.rb"


circular require, warning

dHelmgren · 2019-09-15T22:55:00Z

lib/hotel_manager.rb

+  class Hotel_Manager
+    attr_reader :all_rooms, :available_rooms, :reservations,:block_reservations
+
+    def initialize(hotel_size)


The gist of the instructions tried to lead you to the conclusion that the hotel's size wasn't malleable. 20 rooms, always.

dHelmgren · 2019-09-15T23:17:30Z

lib/hotel_manager.rb

+      end
+
+      avail_rooms -= rooms_blocked
+


This section could use some comments!

dHelmgren · 2019-09-15T23:17:49Z

lib/hotel_manager.rb

+      avail_rooms = @all_rooms
+
+      block_overlaps = @block_reservations.select do |block|
+        block.overlaps?(date_range)


Nice work delegating!

dHelmgren · 2019-09-15T23:19:16Z

lib/refactors.txt

+
+I really considered creating a csv to load from but, I dont think thats a possibility per the project. It couldve been fun(hard) to create and use it though I should definitely think that through a bit more because maybe the refactor wouldnt be worth the time? My tutor mentioned it early on and it did seem both easier and very straightforward and also intimidating bc I know I'm not super comfortable with reading (or writing) to csvs.
+
+I should definitley go back and update the ArgumentErrors, I know I had to much fun with them. I see how giving myself a giggle would be a problem to someone else reviewing my code, especially if those errors were raised. 


I was going to comment about this and then thought "nah, i did that all the time as a student." lol

ohcloud added 14 commits September 3, 2019 14:16

set up files and my version of scaffolding is now complete.

66c9767

trouble shot all the errors, finally green

e9159ec

added date range class, will no longer use rooms.rb. created initiali…

224d01f

…ze for date_range.rb and tests for date_range_tests.

date range logic created. date range tests passing.

35e95ca

test passing for hotelmanagertest instance of rooms and all rooms

2f32eeb

created the length of stay to calulate costs in reservation, built te…

3303a6e

…st, all passing, for it too.

saved file and now cost of stay method works like it should. test pas…

08b6fac

…ses for it. boom boom.

refigured my own logic bc i dont want to be testing 20 different date…

86e81d6

…s. added a parameter to the hotel manager initalize to aid in this. added test for it. we good.

added helper method add_res to hotel manager, added tests, passing. a…

321e7de

…dded date_of_res method too. test pass

completed all tests for all hotel manager methods, all tests pass, wa…

0aff5cf

…ve 2 complete

created block class that is now inheriting from date_range, trying no…

90e9051

…t to couple

deleted room.rb and test file, not using. added logic for hotel block…

4b4e7cc

…, added tests, passing.

moved on over to hotel manager to add the logic that is needed to ens…

ff1d14b

…ure that block.rb works properly. added create block and reserve from block methods. test are all passing. added caveat to block initialize to adhere to the 5 block room max. test pass for that too.

completed refactors.txt

3cbb0ab

dHelmgren reviewed Sep 15, 2019

View reviewed changes

updated and answered design activity.

48a7919

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Leaves - Cloudy#29

Leaves - Cloudy#29
OhCloud wants to merge 15 commits intoAda-C12:masterfrom
OhCloud:master

OhCloud commented Sep 9, 2019

Uh oh!

dHelmgren commented Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

dHelmgren Sep 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		I really considered creating a csv to load from but, I dont think thats a possibility per the project. It couldve been fun(hard) to create and use it though I should definitely think that through a bit more because maybe the refactor wouldnt be worth the time? My tutor mentioned it early on and it did seem both easier and very straightforward and also intimidating bc I know I'm not super comfortable with reading (or writing) to csvs.

		I should definitley go back and update the ArgumentErrors, I know I had to much fun with them. I see how giving myself a giggle would be a problem to someone else reviewing my code, especially if those errors were raised.

Conversation

OhCloud commented Sep 9, 2019

Hotel

Comprehension Questions

Uh oh!

dHelmgren commented Sep 15, 2019

Hotel

What We're Looking For

Test Inspection

Code Review

Overall Feedback

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants