Branches, C. Gutierrez

[CEsGutierrez]

Hotel

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
What was a design challenge that you encountered on this project?	Choosing the boundaries for each class was difficult.
What was a design decision you made that changed over time over the project?	Whether or not to make "block" its own class.
What was a concept you gained clarity on, or a learning that you'd like to share?	TDD made finding the direction of the design a lot easier to determine.
What is an example of a nominal test that you wrote for this assignment? What makes it a nominal case?	Checking that the start date being entered into Booker was before the end date. A user might type these in incorrectly or select them incorrectly.
What is an example of an edge case test that you wrote for this assignment? What makes it an edge case?	Checking that the Block test is receiving dates in forms of instances of Date. These are being passed in from Booker, which already digests the date, so this should not be happening with Block's current set-up.
How do you feel you did in writing pseudocode first, then writing the tests and then the code?	The process was helpful in forcing me to make design decisions as I went without designing too much ahead of time.

[jmaddox19]

Hotel

What We're Looking For

Test Inspection

Workflow	yes (X) / yes but no test / no
Wave 1
List rooms	X
Reserve a room for a given date range	X
Reserve a room (edge case)	X
List reservations for a given date	X
Calculate reservation price	X
Invalid date range produces an error	X
Test coverage	So stinkin' thorough!
Wave 2
View available rooms for a given date range	X
Reserving a room that is not available produces an error	X
Test coverage	So stinkin' thorough!
Wave 3
Create a block of rooms	Yes. One minor thing: The readme said a user could specify a discounted rate.
Check if a block has rooms	X
Reserve a room from a block	X
Test coverage	Great! Love that you made stubs for test that you'd like to write that you weren't able to get to. :)

Code Review

Baseline	Feedback
Used git regularly	Yes!
Answer comprehension questions	X
Design
Each class is responsible for a single piece of the program	Yes!
Classes are loosely coupled	Yes!
Fundamentals
Names variables, classes and modules appropriately	Yes!
Understanding of variable scope - local vs instance	Yes!
Can create complex logical structures utilizing variables	Yes
Appropriately uses methods to break down tasks into smaller simpler tasks	Definitely!
Understands the differences between class and instance methods	Yes
Appropriately uses iterators and Enumerable methods	Yes
Appropriately writes and utilizes classes	Yes!
Appropriately utilizes modules as a namespace	No but not a big deal
Wrap Up
There is a refactors.txt file	No, must have missed that requirement
The file provides a roadmap to future changes	N/A

Overall Feedback

Great work overall! You've built your first project with minimal starting code. This represents an incredible milestone in your journey, and you should be proud of yourself!

I am particularly impressed by the way that you broke your code down into smaller methods for specific types of behavior. And the thoroughness of your testing!

I honestly can't even think of any notable areas for improvement. You've clearly comprehended and applied everything we learned up through last week!