-
Notifications
You must be signed in to change notification settings - Fork 47
Leaves - Tiffany #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Leaves - Tiffany #38
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,49 +1,87 @@ | ||||||
| # Authoring recursive algorithms. Add comments including time and space complexity for each method. | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(n) | ||||||
| # Space complexity: O(n) | ||||||
| def factorial(n) | ||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| raise ArgumentError if n < 0 | ||||||
|
|
||||||
| return 1 if n <= 1 | ||||||
| return n * factorial(n-1) | ||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(s.length) or O(n) | ||||||
| # Space complexity: O(s.length) or O(n) | ||||||
| def reverse(s) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| return s if s.length <= 1 | ||||||
|
|
||||||
| return s[s.length-1] << reverse(s[1..-2]) << s[0] | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Space complexity: O(1) | ||||||
| def reverse_inplace(s) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'll go over this in class. |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| # How would I do this?? | ||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(n) | ||||||
| # Space complexity: O(n) | ||||||
| def bunny(n) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| return 0 if n == 0 | ||||||
|
|
||||||
| return 2 + bunny(n-1) | ||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(s.length) or O(n) | ||||||
| # Space complexity: O(1) | ||||||
| def nested(s) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you have similar time/space issues with the above methods due to creating new arrays. |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| return true if s.nil? | ||||||
| return false if s.length == 1 | ||||||
|
|
||||||
| if s.length == 2 | ||||||
| if s == "()" | ||||||
| return true | ||||||
| else | ||||||
| return false | ||||||
| end | ||||||
| end | ||||||
|
|
||||||
| nested(s[1..-2]) | ||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(array.length) or O(n) | ||||||
| # Space complexity: O(1) | ||||||
| def search(array, value) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you have similar time/space issues with the above methods due to creating new arrays. |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| return false if array.length == 0 | ||||||
|
|
||||||
| return true if array[0] == value | ||||||
|
|
||||||
| search(array[1..-1], value) | ||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(s.length) or O(n) | ||||||
| # Space complexity: O(1) | ||||||
| def is_palindrome(s) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 This works, but you have similar time/space issues with the above methods due to creating new arrays. Remember your minimum space complexity would be O(n), even without creating new arrays with each recursive call. You have to consider the system call stack. |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| return true if s.length <= 1 | ||||||
|
|
||||||
| return false if s[0] != s[-1] | ||||||
|
|
||||||
| is_palindrome(s[1..-2]) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| end | ||||||
|
|
||||||
| # Time complexity: ? | ||||||
| # Space complexity: ? | ||||||
| # Time complexity: O(log(n)) or O(log(m)) whichever is shorter | ||||||
| # Space complexity: O(log(n)) or O(log(m)) whichever is shorter | ||||||
| def digit_match(n, m) | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Correct where n is the size of the number, you could also say O(n) where n is the least number of digits in a number. |
||||||
| raise NotImplementedError, "Method not implemented" | ||||||
| end | ||||||
| if (n % 10) == (m % 10) | ||||||
| if n < 10 || m < 10 | ||||||
| return 1 | ||||||
|
Comment on lines
+75
to
+76
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Glad you caught this |
||||||
| else | ||||||
| return 1 + digit_match(n/10, m/10) | ||||||
| end | ||||||
| else | ||||||
| if n < 10 || m < 10 | ||||||
| return 0 | ||||||
| else | ||||||
| return 0 + digit_match(n/10, m/10) | ||||||
| end | ||||||
| end | ||||||
| end | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍