branches - vi #45
Open
branches - vi #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Dec 18, 2019
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Not bad, you do have some issues with space complexity and one bug in the matching parens, but nice work overall.
| # Space complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def reverse(s) |
| raise NotImplementedError, "Method not implemented" | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def reverse_inplace(s, i = 0, j = -1) |
There was a problem hiding this comment.
The space complexity is O(n) due to the system stack
| raise NotImplementedError, "Method not implemented" | ||
| # Time complexity: O(n) | ||
| # Space complexity: O(n) | ||
| def bunny(n, ears = 0) |
There was a problem hiding this comment.
This works although I was expecting something like:
def bunny(n)
return 0 if n == 0
return 2 + bunny(n-1)
end| if s.length.odd? | ||
| return false | ||
| elsif low < high | ||
| if s[low] != "(" && s[high] != ")" |
There was a problem hiding this comment.
Small bug
Suggested change
| if s[low] != "(" && s[high] != ")" | |
| if s[low] != "(" || s[high] != ")" |
| # Time complexity: ? | ||
| # Time complexity: O(n) | ||
| # Space complexity: ? | ||
| def search(array, value) |
|
|
||
| # Time complexity: O(n) | ||
| # Space complexity: O(1) | ||
| def is_palindrome(s, i = 0, j = -1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.