Branches - Vi Reigosa

[criacuervos]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	This method runs in our files where we define a class. It is a constructor which instantiates the setup of arguments passed into it.
Why do you imagine we made our instance variables readable but not writable?	We would only need to make them writable if we were reassigning our variables. Instead, for this program, they are firmly only to be read.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	If it were a hash we wouldn't be able to define state and behavior to each instance of a planet. Instead they would exist as key value pairs that would require iteration.
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	A hash would be more ideal, since each planet has a "one to many" relationship with various pieces of information unique to that planet. In an array, there would definitely have to be nested arrays of string elements which belong to the array of each planet.
There is a software design principle called the SRP. The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	I believe so. My classes 'Planet' and 'SolarSystem' are responsible for creating instances of each of their namesakes.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	I put 'require_relative' for both the Planet and SolarSystem classes in the main.rb file, where their classes/methods are being passed in

[tildeee]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	x
Variable names	x
Git hygiene	x, I encourage you to keep up small commits with descriptive commit messages!
Planet
initialize method stores parameters as instance variables with appropriate reader methods	x
summary method returns a string	x
SolarSystem
initialize creates an empty list of planets	x
add_planet takes an instance of Planet and adds it to the list	x
list_planets returns a string	x
find_planet_by_name returns the correct instance of Planet	x
CLI
Can list planets and quit	x
Can show planet details	x
Can add a planet	x
Complex functionality is broken out into separate methods	there is opportunity for refactoring here!
Overall

Vi! Well done on this project! You did a great job on this project. In particular, your practice on object-oriented programming and creating classes with the right instance variables and instance methods is great! It looks exactly how I would want it to look

There's opportunity to see what parts of the main.rb file could be refactored into using smaller methods if you had more time on this project. Also, using git in future projects more regularly could be a nice thing to grow in during the upcoming weeks

That being said, well done overall; keep up working with and getting comfortable with classes, instances, instance variables within a class, and instance methods!

[tildeee]

rip

[tildeee]

:)

[tildeee]

Nice! Clever way to make this work

[tildeee]

Nice!

[tildeee]

Minor nitpick: Ruby naming standards would probably format this as all_planets

[tildeee]

Well done! Using .find means that if the planet wasn't found, it will return nil, which gets used appropriately in main.

[tildeee]

Just for the thoroughness of seeing many kinds of syntax (I have no preference), I want to share that this syntax is the same:

    return planets.find do |planet|
      planet.name.downcase == planet_name.downcase
    end