Open
Conversation
Solar SystemWhat We're Looking For
|
jmaddox19
reviewed
Aug 27, 2019
| @@ -0,0 +1,28 @@ | |||
| class Planet | |||
| attr_reader :name, :color, :mass_kg, :distance_from_sun_km, :fun_fact | |||
| def initialize (name:, color:, mass_kg:, distance_from_sun_km:, fun_fact:) | |||
There was a problem hiding this comment.
love that you used keyword arguments here!
| @fun_fact = fun_fact | ||
|
|
||
| if @mass_kg <= 0 | ||
| raise ArgumentError.new "invalid input less than 0 " |
There was a problem hiding this comment.
Great that you validated here!
This would've been above and beyond but wanted to mention that the next step would be to handle (or "rescue") the error in the input_add_planet method so that the user can see an error message and try again rather than the program exiting.
| when "leave" | ||
| choice = false | ||
| when "planet details" | ||
| planet_details(my_solar_system) |
There was a problem hiding this comment.
love that you broke the more complex stuff into separate methods!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solar System
Congratulations! You're submitting your assignment.
Comprehension Questions
initializemethod run? What does it do?Hashinstead of an instance of a class?SolarSystemclass used aHashinstead of anArrayto store the list of planets?requirestatements? Which files neededrequires, and which did not? What is the pattern?