Leaves - Elizabeth

[north108]

Solar System

Congratulations! You're submitting your assignment.

Comprehension Questions

Question	Answer
When does the initialize method run? What does it do?	It runs in planet.rb. It is used to make a new instance of class.
Why do you imagine we made our instance variables readable but not writable?	Because we don't want a user to be ale to change the instances.
How would your program be different if each planet was stored as a Hash instead of an instance of a class?	It would be a lot longer and all on one page of code.
How would your program be different if your SolarSystem class used a Hash instead of an Array to store the list of planets?	Every piece of information would be stored in a key and it would make a long list of hashes in solar_system.
There is a software design principle called the SRP. The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have?	I think my Planet class does because it's only responsibility is to hold planet information. However, my SolarSystem does a few things, including listing planets and creating new planets.
How did you organize your require statements? Which files needed requires, and which did not? What is the pattern?	I didn't have any require statements.

[dHelmgren]

Solar System

What We're Looking For

Feature	Feedback
Baseline
Whitespace (indentation, vertical space, etc)	good
Variable names	good
Git hygiene	Great!
Planet
initialize method stores parameters as instance variables with appropriate reader methods	yes
summary method returns a string	yes
SolarSystem
initialize creates an empty list of planets	yes
add_planet takes an instance of Planet and adds it to the list	yes
list_planets returns a string	yes
find_planet_by_name returns the correct instance of Planet	yes
CLI
Can list planets and quit	yes
Can show planet details	yes
Can add a planet	yes
Complex functionality is broken out into separate methods	yes, but see comments. I would encourage you to group them with the CLI component.
Overall	Solid job overall! It's clear to me that the learning goals on this assignment were met. Take a peek at my comments to see what can be improved, and keep up the hard work!

[dHelmgren]

Using this syntax is almost the same as while true. since play never gets changed, this looks like an infinite loop, which is not so good.

[dHelmgren]

Again, this probably belongs in main.rb

[dHelmgren]

p prints out some extra quotes. It looks weird!

[dHelmgren]

To keep the solar_system at a single responsibility, I would move this communication with the user into your main.rb, perhaps in a helper method.

[dHelmgren]

This is a weird place to call distance_check and mass_check.