Dominique & Emily (aka Eminique)

[eaball35]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We looked at the seed files for what fields were to be expected upon upload.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	O(n) where n is the number of customers or movies.
What is the Big-O time complexity of the POST /rentals/check-in endpoint? What does the time complexity depend on? Explain your reasoning.	O(1) assuming the customer and movie are valid. You never going to have more than one rental being created a time.
Describe a set of positive and negative test cases you implemented for a model.	Positive: Can create a customer given valid fields. Negative: Can't create a customer without valid fields.
Describe a set of positive and negative test cases you implemented for a controller.	Positive: Responds with appropriate request message and body when given valid params. Negative: Responds with bad request message and errors in body when given invalid params.
How does your API respond when bad data is sent to it?	Sends back bad request and errors if said up appropriately
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We didn't user any custom model methods. Some examples we could have used were to update the movies_checkout_count and available_inventory in custom methods, however we chose to do this directly in our checkin/checkout controller action.
Do you have any recommendations on how we could improve this project for the next cohort?	Make the requirements around checkin/checkout more specific. What do you actually want the system to do when rentals occur?
Link to Trello	We used a kanban style approach with notes rather than trello.
Link to ERD	https://www.lucidchart.com/invitations/accept/cea4f163-8ff6-4f06-8697-395ae8c1034c
Summary	EMINIQUE RULEZ 4 LYF!

[beccaelenzil]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Business Logic in Models	see comments around checkin and checkout
All required endpoints return expected JSON data	yes
Requests respond with appropriate HTTP Status Code	yes
Errors are reported	yes
Testing
Passes all Smoke Tests	yes
Model Tests - all relations, validations, and custom functions test positive & negative cases	yes
Controller Tests - URI parameters and data in the request body have positive & negative cases	yes
Overall	Good work overall. It is clear that the learning goals around creating a web api were met. Your code is well written and well tested. I noted a couple places where you should take the business logic out of the control method and put it in a custom model method. Keep up the hard work!