Farah and Katie

[KKennedyCodes]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We inspected the attributes of the seeds and determined that those would be columns in the schema. We also looked forward on the project requirements and adapted our schema.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	O(n) - n being the length of customers/movies
What is the Big-O time complexity of the POST /rentals/check-in endpoint? What does the time complexity depend on? Explain your reasoning.	O(n) - n being the length of customers, movies, and rentals.
Describe a set of positive and negative test cases you implemented for a model.	We verified that all of our models could be created with valid data and would no be created with invalid data. We also tested the relationships. We also tested for nil cases.
Describe a set of positive and negative test cases you implemented for a controller.	We checked to make sure there was available before a movie could be checked out. We also checked the JSON messages. If given an invalid rental, movie, or customer, the JSON response would be not found.
How does your API respond when bad data is sent to it?	It responds with an errors message with either "bad request" or "not found".
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	We originally put increase and decreasing inventory in the model, but due to desperation to get our tests to pass, we moved them to the controller.
Do you have any recommendations on how we could improve this project for the next cohort?	How to troubleshoot smoke testing especially in consideration of strong params. How to read the tests given to us in Postman and how to troubleshoot the tests. i.e. What is the equivalent of binding.pry in postman. Emphasize to rewrite the seed file instead of other database work arounds that can lead to testing errors.
Link to Trello	N/A
Link to ERD	https://www.lucidchart.com/invitations/accept/a1912536-7279-412f-ae94-7f5d15383a8c
Summary	:)

[CheezItMan]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	Good commit messages (mostly), and granular commits, both teammates contributing.
Comprehension questions	Check
General
Business Logic in Models	MISSING See my note
All required endpoints return expected JSON data	Check
Requests respond with appropriate HTTP Status Code	Except for the status code in Checking out a movie
Errors are reported	Check
Testing
Passes all Smoke Tests	Except for creating a rental Yes
Model Tests - all relations, validations, and custom functions test positive & negative cases	Check
Controller Tests - URI parameters and data in the request body have positive & negative cases	Missing some negative cases
Overall	Not bad, you've got some areas to improve, like you created rental routes you don't need, and you missed some areas to test. Take a look at your test coverage for some ideas on what to test. That said, you hit the learning goals here.