Bri & Monick

[brilatimer]

Video Store API

Congratulations! You're submitting your assignment!
If you didn't get to the functionality the question is asking about, reply with what you would have done if you had completed it.

Comprehension Questions

Question	Answer
Explain how you came up with the design of your ERD, based on the seed data.	We reviewed requirements and based our design on that.
What would be the Big-O time complexity of your /customers & /movies endpoints? What does the time complexity depend on? Explain your reasoning.	O(N) for customers and movies. Time complexity depends on the length of customers and movies.
What is the Big-O time complexity of the POST /rentals/check-in endpoint? What does the time complexity depend on? Explain your reasoning.	We did not complete this to answer this question.
Describe a set of positive and negative test cases you implemented for a model.	Positive "is valid with all fields present" and Negative "is invalid without a name"
Describe a set of positive and negative test cases you implemented for a controller.	Negative "should not allow rental if available inventory is 0", Positive: "checks out movie to customer by creating a Rental"
How does your API respond when bad data is sent to it?	Responds with 'bad_request'
Describe one of your custom model methods and why you chose to wrap that functionality into a method.	NA (no custom model methods)
Do you have any recommendations on how we could improve this project for the next cohort?	More detailed expectations and guidance.
Link to Trello	https://trello.com/b/edR5aPt6/video-store-api
Link to ERD	https://www.lucidchart.com/invitations/accept/734128bc-642f-485f-956c-cc9dc413f177
Summary	We tried really hard ^.^

[beccaelenzil]

Video Store

What We're Looking For

Feature	Feedback
Core Requirements
Git hygiene	yes
Comprehension questions	yes
General
Business Logic in Models	yes
All required endpoints return expected JSON data	yes
Requests respond with appropriate HTTP Status Code	yes
Errors are reported	yes
Testing
Passes all Smoke Tests	These tests for wave 2 are failing
create movie fail: Status code is 200	AssertionError: expected false to be truthy. However, it seems appropriate that you respond with created (which is a 201)
Get Customers: All Customers have movies_checked_out_count
Get Show Movie From List: Movie has available_inventory
Get Show Created Movie: Movie has available_inventory
Model Tests - all relations, validations, and custom functions test positive & negative cases	see comments
Controller Tests - URI parameters and data in the request body have positive & negative cases	see comments
Overall	Good work overall. You demonstrated an understanding of creating a web API. I didn't dig quite deep enough to fully understand to what extent you completed the optional features, as these smoke tests are not passing, but I do see some of these functionality in the code. I would be happy to talk through this with you. I made a few comments to indicate where logic in your controller should be a model method, a few places were your tests could be a bit more thorough, and where the implementation of a controller action doesn't quite follow the spec. Please follow up if you have questions.