Skip to content

Conversation

@aecombs
Copy link

@aecombs aecombs commented Feb 14, 2020

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? The signature and block
What are the advantages of using git when collaboratively working on one code base? Both can be working on the code at the same time and have a record of past versions.
What kind of relationship did you and your pair have with the unit tests? They were difficult and frustrating to pass, but ultimately helped us to write our code in a way that fulfilled requirements.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? Yes! We used .map() for the dictionary at the end. It helped us to format our dictionary.
What was one method you and your pair used to debug code? We used print statements a lot, but started to make use of the debugger in VS Code to see the step-by-step process.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? Communication as well as coding process. We were on similar levels of understanding, but had trouble with communicating where we were and this is something we will want to work on in the future.

@beccaelenzil
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) Your draw_letters method could (while unlikely) draw a z 10 times.
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements ✔️
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging ✔️

Additional Feedback

Great work on your first pair programming project! You did a great job working through some tricky logic, and it is clear that the learning goals around defining and using methods were met. I've left a few comments for you to review. Keep up the hard work!

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants