Skip to content

Sara and Hala - SPACE #20

Open
sarabrandao21 wants to merge 5 commits intoAda-C13:masterfrom
sarabrandao21:master
Open

Sara and Hala - SPACE #20
sarabrandao21 wants to merge 5 commits intoAda-C13:masterfrom
sarabrandao21:master

Conversation

@sarabrandao21
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? def to end(method), method signature, return.
What are the advantages of using git when collaboratively working on one code base? Checking if we both made changes at the same part of the code and give us the chance to select which part we wanna to keep without the need of manually doing it. Very convenient to push and pull.
What kind of relationship did you and your pair have with the unit tests? by collaborating with my partner refactoring till we passed all the tests.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? each to loop through arrays and hashes was very useful. Max, include, reverse and others.
What was one method you and your pair used to debug code? talking out loud and following the code step by step.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? this code was submitted before writing pair feedback.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass

Overall Feedback

Great work! You may not have completely finished but everything you do have looks really great!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation Almost! (Line 50)
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants