Skip to content

Conversation

@mheshmati-tech
Copy link

@mheshmati-tech mheshmati-tech commented Feb 15, 2020

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? They perform a procedure that is the block of code executing, returns a value when the method is called for/invoked. Methods are nice since it prevents code redundancy and divides solutions into small pieces of code.
What are the advantages of using git when collaboratively working on one code base? Git allows for both users to make changes and add to the file- both partners can work remotely and share their work via GitHub.
What kind of relationship did you and your pair have with the unit tests? It was nice to know our code was running although for instance there was a bug in our wave-2 method that the unit test didn't test for. The bug was that if the word had two repeated letters, that letter would be taken out and thus the program input an incorrect message saying the word wasn't in the word bank. So that was a flaw, but otherwise, the green colors were encouraging.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? No, we're sure that there are some places in our code that they can be incorporated and will be more mindful in using them in the future, but our code runs smoothly without them.
What was one method you and your pair used to debug code? Used the debugger. Got the chance to get familiar with it which was neat.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We certainly learned a lot about our communication styles, strength and weakness. Talked about what we could have done differently if we were to pair up in the future and what are some good strategies for working in the field on a group project like this one.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants