Space - Stephanie & Olivia

[mulhoo]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	Methods are composed signature, and block. They start with a def and end. The signature include the method name and parameters. Calling the method requires the name and arguments.
What are the advantages of using git when collaboratively working on one code base?	The advantages of using git are that you can push any updates you have made and your pair can get the most updated version. You can also both be working on different pieces in coordination.
What kind of relationship did you and your pair have with the unit tests?	We used the test to see what was wrong with our code. We didn't love the tests because we thought we had our code working, just not the exact way the tests wanted us to.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	Yes, we used a lot. We use .max to find the highest scores, .shuffle and .take to make the hand. We use .flatten to make the array of letter options. We use .clone to make a new array that we could alter without affecting.
What was one method you and your pair used to debug code?	We did a few things, running separate chunks through REPL, and checking what errors or failures our rake test was having, and modified to fit requirements. We also checked in with a TA.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We could have been better about working on one keyboard. We also collectively didn't keep us on track. We went down rabbit holes and tried to make things better and prettier before we got everything to work.

[jmaddox19]

Calculator

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	Definitely a good idea to remember to commit frequently in the future. I know it's hard to think of at first :)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass
Utilizes unit tests to verify code; all tests for score_word pass
Utilizes unit tests to verify code; all tests for highest_score_from pass

Overall Feedback

I totally understand getting caught up on cleaning code up before getting everything working. It's a tradeoff that can be hard to make. Because of how much learning opportunity this exercise provides that y'all haven't been able to benefit from yet, we ask that you redo this. We will get back to you soon about how and when this will be done.

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging	✔️

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

[jmaddox19]

2nd pass after full submission

Adagrams

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	Definitely a good idea to remember to commit frequently in the future. I know it's hard to think of at first :)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	✔️

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Glad y'all were able to talk to Chris and understand the git issue! The code looks great!

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever
Descriptive/Readable	✅
Concise
Logical/Organized	✅