Skip to content

Hannah & Angela - Time#24

Open
angethuy wants to merge 7 commits intoAda-C13:masterfrom
stpatrickschild:master
Open

Hannah & Angela - Time#24
angethuy wants to merge 7 commits intoAda-C13:masterfrom
stpatrickschild:master

Conversation

@angethuy
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? Method signature with optional parameters, block, return
What are the advantages of using git when collaboratively working on one code base? Easier sharing of code, decentralized code management. Ability to view commit history to track changes and progress.
What kind of relationship did you and your pair have with the unit tests? We were so excited about the code that we forgot about the unit tests until around stage 4... but once we started using them, they were "helpful" (reading them is still difficult, intimidating, and mysterious sometimes) in helping us narrow down where the bug might be. We also enjoyed seeing the green/red numbers fluctuate.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used "select", "min_by", and "max_by" to manipulate our data set of words to satisfy varying conditions. "Select" helped us quickly grab a subset of valid results. "Max_by" let us find the highest score, and "min_by" made it easy to run the final tie-breaker test of grabbing the smallest word.
What was one method you and your pair used to debug code? We still printed A LOT of strings to console. We're not quite comfortable with using the debugger yet, however we've gotten better about reading test result output.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We started our project by establishing hopes/expectations/goals for the project. In our post-project feedback, we both agreed that it helped guide our mindset and focus. Halfway through the project we both had a moment when we discussed our personal fears, and it was great to be open about that topic with each other because we were able to help alleviate the other's concerns.

@beccaelenzil
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements ✔️
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging ✔️

Additional Feedback

Great work on your first pair programming project. I've left a few comments for you to review. You have worked through some tricky logic in clever ways. In addition, it is clear the learning goals are defining and using methods, and using unit tests were met. Keep up the hard work.

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever
Descriptive/Readable
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants