Space - Faezeh - Suely

[SuelyBarreto]

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature	Feedback
What are the components that make up a method?	A method has a signature, which consists of a name and possibly parameters and has a block of code that executes what we want the method to do. If the method has parameters, it requires arguments to be passed to it. The method needs to be called or invoked to execute.
What are the advantages of using git when collaboratively working on one code base?	git allows multiple collaborators to work on the same file at the same time.
What kind of relationship did you and your pair have with the unit tests?	We could run the tests or rake only on the computer that we were developing the source code on.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful?	We used .map, .include?, .find_index, .select enumerables. .map was helpful in multiple methods where we collected strings of words in arrays and wanted to compare their scores as integers.
What was one method you and your pair used to debug code?	We raked, run the code using the wave files. We tested different ways to code using terminal irb.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	We talked with the room instructor (Devin) and we were told that the feedback session will be on Friday.

[jmaddox19]

Calculator

Major Learning Goals/Code Review

Criteria	yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.)	✔️
Uses correct syntax for conditional logic and iteration	✔️
Practices git with at least 3 small commits and meaningful commit messages	✔️ Yay! 👏👏👏 (Though even more frequent commits would serve you well in the future)
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures	✔️
Practices pair programming; the reflection question on pair programming is answered	It looks like y'all did the peer feedback session but turned this in before doing it so I can't see the thoughts. Not a big deal :)

Functional Requirements

Functional Requirement	yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.)	✔️ The data structure for letter_dist certainly works but it's generally not considered best practice to use an array with implicit keys (meaning the code doesn't specify which letter goes with which index). It's best to use a hash in such cases. (Please chat with me if my messaging here isn't clear)
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass	✔️
Utilizes unit tests to verify code; all tests for score_word pass	✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass	✔️

Overall Feedback

Great work!

Overall Feedback	Criteria	yes/no
Green (Meets/Exceeds Standards)	4+ in Code Review && 3+ in Functional Requirements	✔️
Yellow (Approaches Standards)	3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard)	0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Elegant/Clever
Descriptive/Readable	✅
Concise
Logical/Organized