Skip to content

Quin & Yesenia - Time #7

Open
quinqu wants to merge 4 commits intoAda-C13:masterfrom
quinqu:master
Open

Quin & Yesenia - Time #7
quinqu wants to merge 4 commits intoAda-C13:masterfrom
quinqu:master

Conversation

@quinqu
Copy link

@quinqu quinqu commented Feb 14, 2020

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? a signature and parameters if needed.
What are the advantages of using git when collaboratively working on one code base? All collaborators can have the same updates version and doesn't allow new versions to be pushed if the "pusher" doesn't have the updated code
What kind of relationship did you and your pair have with the unit tests? confused at first, but as we started fixing the fails/errors we grew more comfortable with it
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? we used max_by and this was helpful to find the word with the highest score
What was one method you and your pair used to debug code? Looking at the test file output and tracing it back to the errors
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? we had different ways of starting a project but eventually collaborated and finished it. We weren't on the same page about the highest_score_from method, but with help from a TA it was helpful to understand what we needed to do to get the method working.

@jmaddox19
Copy link

Adagrams

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages Technically there are 3+ commits but didn't start committing until the project was practically done. Definitely worth committing throughout your work on the project in the future :)

| Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures | ✔️
| Practices pair programming; the reflection question on pair programming is answered | ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation
Elegant/Clever ✅ Great use of enumerable methods!
Descriptive/Readable ✅ The comments definitely help :)
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants