Skip to content

Conversation

@ubeninja77
Copy link

Assignment Submission: Adagrams

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Feature Feedback
What are the components that make up a method? Method signature with argument, blocks, end.
What are the advantages of using git when collaboratively working on one code base? We are able to work on separate sections of the code and make changes at the same time.
What kind of relationship did you and your pair have with the unit tests? Two brains brings more ideas. Talking to each other about what is passing/failing and what each of us interprets why it's failing.
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? We used inject. We used it in the method to return the total score on the word submitted.
What was one method you and your pair used to debug code? An previous Adie, two TA's, and puts statements after each method.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We referred to the ask/guess culture and shared which we identified with. During an earlier ice breaker, we identified as being Asian and already have that guess culture built in due to the way we were raised.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly creates and calls methods with proper syntax (parameters, return statements, etc.) ✔️
Uses correct syntax for conditional logic and iteration ✔️
Practices git with at least 3 small commits and meaningful commit messages ✔️ Yay! 👏👏👏
Utilizes unit tests to verify code; tests can run using the command $ rake and we see test successes and/or failures ✔️
Practices pair programming; the reflection question on pair programming is answered ✔️

Functional Requirements

Functional Requirement yes/no
For the draw_letters method, there is an appropriate data structure to store the letter distribution. (You are more likely to draw an 'E' than an 'X'.) ✔️
Utilizes unit tests to verify code; all tests for draw_letters and uses_available_letters? pass ✔️
Utilizes unit tests to verify code; all tests for score_word pass ✔️
Utilizes unit tests to verify code; all tests for highest_score_from pass ✔️

Overall Feedback

Great work!!

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 4+ in Code Review && 3+ in Functional Requirements ✔️
Yellow (Approaches Standards) 3+ in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0-2 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality Yes?
Perfect Indentation There are a couple funky indentation things going on where you accidentally indented an extra space (lines 86, 111, 67)
Elegant/Clever
Descriptive/Readable
Concise
Logical/Organized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants