Nora, Jessica, Emily, Kate: PLANTSY #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash messages added to application
Feat: basic styling
Order + order item functions km june11
Add product
Feat links and styles
Nora clean up
simple cov order controller test 90%
Jessica misc final changes
Merchant order status
bEtsyFunctional Requirements: Manual Testing
Major Learning Goals/Code Review
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
Overall FeedbackGreat work overall! You've built a fully functional web store from top to bottom. This represents a huge amount of work, and you should be proud of yourselves!. I am particularly impressed by the way that you worked together as a team and how thorough your tests were of the things you did test. I do see some room for improvement around putting more logic in the model and attention to detail. There were some small things that slipped through the cracks (see comments). bEtsy is a huge project on a very short timeline, and this feedback should not at all diminish the magnitude of what you've accomplished. Keep up the hard work! Overall: Meets or Exceeds Standard Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it. |
kaidamasaki
reviewed
Jun 26, 2020
|
|
||
| #Login | ||
| get "/auth/github", as: "github_login" | ||
| get "/auth/:provider/callback", to: "merchants#create" |
There was a problem hiding this comment.
To of your tests fail because this isn't named.
Suggested change
| get "/auth/:provider/callback", to: "merchants#create" | |
| get "/auth/:provider/callback", to: "merchants#create", as: "auth_callback" |
Comment on lines
+8
to
+17
| def index | ||
| if params[:product_id] # This is the nested route, /products/:product_id/order_items | ||
| product = Product.find_by(id: params[:product_id]) | ||
| order_items = product.order_items.as_json(only: [:id, :name, :price, :quantity]) | ||
| render json: order_items, status: :ok | ||
| else # This is the 'regular' route, /order_items | ||
| order_items = OrderItem.all.as_json(only: [:id, :name, :price, :quantity]) | ||
| render json: order_items, status: :ok | ||
| end | ||
| end |
|
|
||
| if @order_item.nil? | ||
| # head :not_found | ||
| redirect_to dashboard_path |
There was a problem hiding this comment.
Adding a flash message here would be nice.
| end | ||
|
|
||
| if @product.status == false && @product.merchant_id != session[:user_id] | ||
| flash[:error] = "Oops. That plant isn't available. Let's find you another beautiful plant." |
| @@ -0,0 +1,3 @@ | |||
| class Category < ApplicationRecord | |||
There was a problem hiding this comment.
You should probably require a name to exist.
| <%= link_to "Merchants", merchants_path %> | ||
| </nav> | ||
|
|
||
| <section class="navigation-bar--right-side"> |
There was a problem hiding this comment.
You should avoid things like right-side in class names.
You might want to move this to the left side at some point and then that would be confusing or require a rename.
| <button type="button" class="btn btn-primary"><%= link_to "Add a product", new_product_path %></button> | ||
| <button type="button" class="btn btn-primary"><%= link_to "Add a category", new_category_path %></button> | ||
| </section> | ||
| <br /> |
There was a problem hiding this comment.
You should avoid using <br />s if you can. It's cleaner just to add a margin-bottom or margin-top to something.
| <% if @cart_items %> | ||
| <% @cart_items.each do |item| %> | ||
| <section class="cart-item"> | ||
| <%= image_tag(item.photo_url, alt: "photo of the cart item") %> |
There was a problem hiding this comment.
For an alt tag it would probably be better to make it a little more specific, maybe:
Suggested change
| <%= image_tag(item.photo_url, alt: "photo of the cart item") %> | |
| <%= image_tag(item.photo_url, alt: "photo of the #{item.name}") %> |
| <h2>Confirmation: Order placed!</h2> | ||
| <ul> | ||
| <li> | ||
| <strong>Order Placed At: </strong><%= @cart.updated_at.strftime('%a %b %d %H:%M:%S %Z %Y').in_time_zone("Pacific Time (US & Canada)") %> |
There was a problem hiding this comment.
I like that you specified the time zone.
| <% @products.each do |product| %> | ||
| <ul class="product-listing"> | ||
| <li> | ||
| <% if product.photo_url == nil || product.photo_url.length < 1 %> |
There was a problem hiding this comment.
It's clearer to use empty? instead of length < 1:
Suggested change
| <% if product.photo_url == nil || product.photo_url.length < 1 %> | |
| <% if product.photo_url == nil || product.photo_url.empty? %> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: bEtsy
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions. These should be answered by all members of your team, not by a single teammate.
Reflection