Skip to content

Conversation

@yesentorres
Copy link

Assignment Submission: Calculator

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions:

Reflection

Question Answer
What went well in your code style, such as indentation, spacing, variable names, readability, etc.? What was lacking? Definitely indentation, spacing, and readability. Could have used better variable names.
How did your code keep track of user input? The code keeps track of user input by using until loops to verify the input matched my specifications, then assigning the user input to variables once the specifications are met.
How did your code determine what operation to perform? I used a case/when statement that ran the appropriate operation based on which operation the user typed in.
What opportunities exist to create small methods for this project? Methods for the math operations, the user input validation checks, and even though I didn't manage to create it, a method could be used to convert user input to either a float or integer.
In the next project, what would you change about your process? What would you keep doing? I would like to keep adding comments at the end of my program that state what improvements I could of added that I didn't manage to do, and the missing optional enhancements that were suggested in the original prompt. I would like to set aside more time after official Ada hours to continue working on the assignment.

@jmaddox19
Copy link

Calculator

Major Learning Goals/Code Review

Criteria yes/no, and optionally any details/lines of code to reference
Correctly uses conditionals (if/else/elsif) ✔️
Correctly uses loops (while/until) ✔️
Correctly uses gets.chomp ✔️
Correctly uses variables ✔️
Correctly creates and uses custom methods Yes, though there's some repeated code that shows there's more opportunity for that.

Functional Requirements

Functional Requirement yes/no
User can input two numbers and an operator and perform addition ✔️
User can input in two numbers and an operator and can perform subtraction ✔️
User gets feedback from the CLI when attempting to divide by zero, and the program does not give an error No

Overall Feedback

Overall Feedback Criteria yes/no
Green (Meets/Exceeds Standards) 3+ in Code Review && 2+ in Functional Requirements ✔️
Yellow (Approaches Standards) 2 in Code Review && 2+ in Functional Requirements
Red (Not at Standard) 0,1 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging

Love that you added unique language to the user for each operation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants